[PR #2215] [MERGED] Retry tcp on udp io errors #2881

New issue

Closed

opened 2026-03-16 11:13:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:13:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2215
Author: @bluejekyll
Created: 5/18/2024
Status: ✅ Merged
Merged: 5/18/2024
Merged by: @djc

Base: main ← Head: retry-tcp-on-udp-io-errors

📝 Commits (2)

a455ac7 remove IO error from ResolveError and only use ProtoError(Io)
5607075 retry all tcp on all IO errors recieved from UDP requests

📊 Changes

3 files changed (+8 additions, -8 deletions)

View changed files

📝 crates/proto/src/error.rs (+6 -0)
📝 crates/resolver/src/error.rs (+1 -7)
📝 crates/resolver/src/name_server/name_server_pool.rs (+1 -1)

📄 Description

fixes: #2197
closes: #2204

@djc, I took a slightly different and simpler tack with this. It will retry TCP on any IO error, which feels correct to me.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2215 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 5/18/2024 **Status:** ✅ Merged **Merged:** 5/18/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `retry-tcp-on-udp-io-errors` --- ### 📝 Commits (2) - [`a455ac7`](https://github.com/hickory-dns/hickory-dns/commit/a455ac7c04104a3bd7f250010e923ca555ce3f76) remove IO error from ResolveError and only use ProtoError(Io) - [`5607075`](https://github.com/hickory-dns/hickory-dns/commit/5607075f2fdbe3100ac28e5b354590b0b1192a16) retry all tcp on all IO errors recieved from UDP requests ### 📊 Changes **3 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/error.rs` (+6 -0) 📝 `crates/resolver/src/error.rs` (+1 -7) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+1 -1) </details> ### 📄 Description fixes: #2197 closes: #2204 @djc, I took a slightly different and simpler tack with this. It will retry TCP on any IO error, which feels correct to me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>