[PR #2171] [MERGED] Handle shutdown sockets #2858

Closed
opened 2026-03-16 11:11:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2171
Author: @dlon
Created: 3/12/2024
Status: Merged
Merged: 3/16/2024
Merged by: @bluejekyll

Base: mainHead: handle-shutdown-sockets


📝 Commits (1)

  • 8d8c8d0 Break when socket is unexpectedly shut down

📊 Changes

1 file changed (+42 additions, -4 deletions)

View changed files

📝 crates/server/src/server/server_future.rs (+42 -4)

📄 Description

Fix #2169. The server stops accepting connections if this fails due to an unrecoverable error. The list of "unrecoverable" errors might not be exhaustive.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2171 **Author:** [@dlon](https://github.com/dlon) **Created:** 3/12/2024 **Status:** ✅ Merged **Merged:** 3/16/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `handle-shutdown-sockets` --- ### 📝 Commits (1) - [`8d8c8d0`](https://github.com/hickory-dns/hickory-dns/commit/8d8c8d076492f1fd15514d7b448a016d367c0f39) Break when socket is unexpectedly shut down ### 📊 Changes **1 file changed** (+42 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/server/server_future.rs` (+42 -4) </details> ### 📄 Description Fix #2169. The server stops accepting connections if this fails due to an unrecoverable error. The list of "unrecoverable" errors might not be exhaustive. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:11:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2858
No description provided.