[PR #2139] [CLOSED] Draft code to add TlsConnect trait #2834

New issue

Closed

opened 2026-03-16 11:10:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:10:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2139
Author: @zh-jq-b
Created: 2/7/2024
Status: ❌ Closed

Base: main ← Head: crypto-general

📝 Commits (2)

a69d627 client: add TlsConnect trait
dd4d5af client: add h2 module to make use of TlsConnect

📊 Changes

9 files changed (+358 additions, -13 deletions)

View changed files

📝 Cargo.lock (+3 -0)
📝 crates/client/Cargo.toml (+6 -2)
📝 crates/client/src/h2/client_connection.rs (+0 -0)
➕ crates/client/src/h2/mod.rs (+179 -0)
📝 crates/client/src/lib.rs (+6 -11)
➕ crates/client/src/tls/connect/mod.rs (+18 -0)
➕ crates/client/src/tls/connect/rustls.rs (+50 -0)
➕ crates/client/src/tls/mod.rs (+83 -0)
📝 crates/proto/src/h2/h2_client_stream.rs (+13 -0)

📄 Description

See https://github.com/hickory-dns/hickory-dns/issues/2137

I add a TlsConnect trait in this draft PR, it will be possible for users to use other tls crates to do DoT or DoH.

What do you think about this?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2139 **Author:** [@zh-jq-b](https://github.com/zh-jq-b) **Created:** 2/7/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `crypto-general` --- ### 📝 Commits (2) - [`a69d627`](https://github.com/hickory-dns/hickory-dns/commit/a69d627b337aef63a084b458050759bf64ebb184) client: add TlsConnect trait - [`dd4d5af`](https://github.com/hickory-dns/hickory-dns/commit/dd4d5afddac3b9bdd47b6c0a1f55c9e69a489e03) client: add h2 module to make use of TlsConnect ### 📊 Changes **9 files changed** (+358 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+3 -0) 📝 `crates/client/Cargo.toml` (+6 -2) 📝 `crates/client/src/h2/client_connection.rs` (+0 -0) ➕ `crates/client/src/h2/mod.rs` (+179 -0) 📝 `crates/client/src/lib.rs` (+6 -11) ➕ `crates/client/src/tls/connect/mod.rs` (+18 -0) ➕ `crates/client/src/tls/connect/rustls.rs` (+50 -0) ➕ `crates/client/src/tls/mod.rs` (+83 -0) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+13 -0) </details> ### 📄 Description See https://github.com/hickory-dns/hickory-dns/issues/2137 I add a TlsConnect trait in this draft PR, it will be possible for users to use other tls crates to do DoT or DoH. What do you think about this? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>