[PR #2130] [MERGED] Use cargo environment variables for path to executable. #2829

New issue

Closed

opened 2026-03-16 11:10:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:10:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2130
Author: @sjbronner
Created: 1/25/2024
Status: ✅ Merged
Merged: 1/27/2024
Merged by: @bluejekyll

Base: main ← Head: main

📝 Commits (2)

de12492 Update mod.rs
705ede1 Update comparison_benches.rs

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 bin/benches/comparison_benches.rs (+1 -1)
📝 bin/tests/server_harness/mod.rs (+1 -1)

📄 Description

Two files have hardcoded paths to compiled executables. Cargo provides environment variables for those, allowing for alternative target directories. This allows something like cargo test --release.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2130 **Author:** [@sjbronner](https://github.com/sjbronner) **Created:** 1/25/2024 **Status:** ✅ Merged **Merged:** 1/27/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`de12492`](https://github.com/hickory-dns/hickory-dns/commit/de1249274d890570fdd17d453b0513bd6b3420a9) Update mod.rs - [`705ede1`](https://github.com/hickory-dns/hickory-dns/commit/705ede11d43e02482bed870214f4e13261272a2a) Update comparison_benches.rs ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bin/benches/comparison_benches.rs` (+1 -1) 📝 `bin/tests/server_harness/mod.rs` (+1 -1) </details> ### 📄 Description Two files have hardcoded paths to compiled executables. Cargo provides environment variables for those, allowing for alternative target directories. This allows something like ``cargo test --release``. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>