[PR #2124] [MERGED] when comparing IP addresses for UDP, only check IP and Port #2826

New issue

Closed

opened 2026-03-16 11:10:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:10:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2124
Author: @bluejekyll
Created: 1/3/2024
Status: ✅ Merged
Merged: 1/5/2024
Merged by: @bluejekyll

Base: main ← Head: fix-ipv6-comparison

📝 Commits (4)

54501fe when comparing IP addresses for UDP, only check IP and Port
2752d73 restructure test to use common regex
045b074 properly extract both IPv6 and IPv4 addresses for named tests
600ac91 reenable ipv6 tests on linux

📊 Changes

13 files changed (+106 additions, -105 deletions)

View changed files

📝 bin/tests/named_https_tests.rs (+3 -1)
📝 bin/tests/named_quic_tests.rs (+3 -1)
📝 bin/tests/named_rustls_tests.rs (+3 -1)
📝 bin/tests/named_test_rsa_dnssec.rs (+3 -1)
📝 bin/tests/named_tests.rs (+20 -10)
📝 bin/tests/server_harness/mod.rs (+65 -65)
📝 crates/proto/src/rustls/tests.rs (+1 -4)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+1 -4)
📝 crates/proto/src/tcp/tcp_stream.rs (+1 -4)
📝 crates/proto/src/udp/udp_client_stream.rs (+3 -5)
📝 crates/proto/src/udp/udp_stream.rs (+1 -4)
📝 crates/proto/tests/openssl_tests.rs (+1 -4)
📝 crates/server/src/server/protocol.rs (+1 -1)

📄 Description

fixes: #2081

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2124 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/3/2024 **Status:** ✅ Merged **Merged:** 1/5/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix-ipv6-comparison` --- ### 📝 Commits (4) - [`54501fe`](https://github.com/hickory-dns/hickory-dns/commit/54501fe21ca69a66b22abc389ae8f6b51233baf3) when comparing IP addresses for UDP, only check IP and Port - [`2752d73`](https://github.com/hickory-dns/hickory-dns/commit/2752d73613e0f6feeabef651fbfc2edd5a25f00f) restructure test to use common regex - [`045b074`](https://github.com/hickory-dns/hickory-dns/commit/045b0742f386d5460634ade761149b504dee72b2) properly extract both IPv6 and IPv4 addresses for named tests - [`600ac91`](https://github.com/hickory-dns/hickory-dns/commit/600ac91f93812e3d7f04dfac58328a3ef9fd8d43) reenable ipv6 tests on linux ### 📊 Changes **13 files changed** (+106 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/named_https_tests.rs` (+3 -1) 📝 `bin/tests/named_quic_tests.rs` (+3 -1) 📝 `bin/tests/named_rustls_tests.rs` (+3 -1) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+3 -1) 📝 `bin/tests/named_tests.rs` (+20 -10) 📝 `bin/tests/server_harness/mod.rs` (+65 -65) 📝 `crates/proto/src/rustls/tests.rs` (+1 -4) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+1 -4) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+1 -4) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+3 -5) 📝 `crates/proto/src/udp/udp_stream.rs` (+1 -4) 📝 `crates/proto/tests/openssl_tests.rs` (+1 -4) 📝 `crates/server/src/server/protocol.rs` (+1 -1) </details> ### 📄 Description fixes: #2081 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>