[PR #2114] [MERGED] Gate tests on required features #2818

New issue

Closed

opened 2026-03-16 11:09:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:09:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2114
Author: @alexanderkjall
Created: 12/23/2023
Status: ✅ Merged
Merged: 1/1/2024
Merged by: @bluejekyll

Base: main ← Head: gate-tests-on-required-features

📝 Commits (1)

c8eecfb Gate tests on required features

📊 Changes

2 files changed (+2 additions, -0 deletions)

View changed files

📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+1 -0)
📝 crates/proto/tests/dnssec_presentation_format_tests.rs (+1 -0)

📄 Description

Without this patch we get this error from cargo test --no-default-features --features dnssec :

error[E0599]: no method named `to_vec` found for reference `&Digest` in the current scope
  --> crates/proto/tests/dnssec_presentation_format_tests.rs:53:25
   |
53 |         digest.as_ref().to_vec(),
   |                         ^^^^^^ method not found in `&Digest`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `hickory-proto` (test "dnssec_presentation_format_tests") due to previous error

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2114 **Author:** [@alexanderkjall](https://github.com/alexanderkjall) **Created:** 12/23/2023 **Status:** ✅ Merged **Merged:** 1/1/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `gate-tests-on-required-features` --- ### 📝 Commits (1) - [`c8eecfb`](https://github.com/hickory-dns/hickory-dns/commit/c8eecfbe57779e5bbb7b8ca4eb95f39596bbab67) Gate tests on required features ### 📊 Changes **2 files changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+1 -0) 📝 `crates/proto/tests/dnssec_presentation_format_tests.rs` (+1 -0) </details> ### 📄 Description Without this patch we get this error from `cargo test --no-default-features --features dnssec` : ``` error[E0599]: no method named `to_vec` found for reference `&Digest` in the current scope --> crates/proto/tests/dnssec_presentation_format_tests.rs:53:25 | 53 | digest.as_ref().to_vec(), | ^^^^^^ method not found in `&Digest` For more information about this error, try `rustc --explain E0599`. error: could not compile `hickory-proto` (test "dnssec_presentation_format_tests") due to previous error ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>