[PR #2018] [MERGED] Make DnsHandle::send &self instead of &mut self #2758

New issue

Closed

opened 2026-03-16 11:06:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:06:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2018
Author: @ibigbug
Created: 9/4/2023
Status: ✅ Merged
Merged: 9/7/2023
Merged by: @djc

Base: main ← Head: make-it-no-mut

📝 Commits (4)

54a8d27 make it no mut
ca798f2 cargo fix
74fb1c8 Merge branch 'main' into make-it-no-mut
8f44dba Update crates/proto/src/xfer/dnssec_dns_handle.rs

📊 Changes

20 files changed (+57 additions, -56 deletions)

View changed files

📝 bin/tests/server_harness/mut_message_client.rs (+1 -1)
📝 crates/client/src/client/async_client.rs (+1 -1)
📝 crates/client/src/client/async_secure_client.rs (+1 -1)
📝 crates/client/src/client/client.rs (+1 -1)
📝 crates/client/src/client/memoize_client_handle.rs (+4 -4)
📝 crates/proto/src/xfer/dns_exchange.rs (+1 -1)
📝 crates/proto/src/xfer/dns_handle.rs (+2 -2)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+3 -3)
📝 crates/proto/src/xfer/mod.rs (+3 -2)
📝 crates/proto/src/xfer/retry_dns_handle.rs (+4 -4)
📝 crates/recursor/src/recursor_pool.rs (+1 -1)
📝 crates/resolver/src/lookup.rs (+4 -4)
📝 crates/resolver/src/lookup_ip.rs (+1 -1)
📝 crates/resolver/src/name_server/connection_provider.rs (+1 -1)
📝 crates/resolver/src/name_server/name_server.rs (+4 -4)
📝 crates/resolver/src/name_server/name_server_pool.rs (+4 -4)
📝 tests/integration-tests/src/mock_client.rs (+2 -2)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+15 -15)
📝 tests/integration-tests/tests/retry_dns_handle_tests.rs (+3 -3)
📝 tests/integration-tests/tests/truncation_tests.rs (+1 -1)

📄 Description

following #1933

making the trait non mut so usage of it doesn't need Mutex

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2018 **Author:** [@ibigbug](https://github.com/ibigbug) **Created:** 9/4/2023 **Status:** ✅ Merged **Merged:** 9/7/2023 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `make-it-no-mut` --- ### 📝 Commits (4) - [`54a8d27`](https://github.com/hickory-dns/hickory-dns/commit/54a8d27bf2a5647ced707a8dacdb2dd957899c07) make it no mut - [`ca798f2`](https://github.com/hickory-dns/hickory-dns/commit/ca798f2b931b9c85cb28bdaad7a922f3049c9394) cargo fix - [`74fb1c8`](https://github.com/hickory-dns/hickory-dns/commit/74fb1c8a4010110491efca7f07e388ab5effc037) Merge branch 'main' into make-it-no-mut - [`8f44dba`](https://github.com/hickory-dns/hickory-dns/commit/8f44dbacbea64440bc1339a02aa90a7eeb04247e) Update crates/proto/src/xfer/dnssec_dns_handle.rs ### 📊 Changes **20 files changed** (+57 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/server_harness/mut_message_client.rs` (+1 -1) 📝 `crates/client/src/client/async_client.rs` (+1 -1) 📝 `crates/client/src/client/async_secure_client.rs` (+1 -1) 📝 `crates/client/src/client/client.rs` (+1 -1) 📝 `crates/client/src/client/memoize_client_handle.rs` (+4 -4) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_handle.rs` (+2 -2) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+3 -3) 📝 `crates/proto/src/xfer/mod.rs` (+3 -2) 📝 `crates/proto/src/xfer/retry_dns_handle.rs` (+4 -4) 📝 `crates/recursor/src/recursor_pool.rs` (+1 -1) 📝 `crates/resolver/src/lookup.rs` (+4 -4) 📝 `crates/resolver/src/lookup_ip.rs` (+1 -1) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+1 -1) 📝 `crates/resolver/src/name_server/name_server.rs` (+4 -4) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+4 -4) 📝 `tests/integration-tests/src/mock_client.rs` (+2 -2) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+15 -15) 📝 `tests/integration-tests/tests/retry_dns_handle_tests.rs` (+3 -3) 📝 `tests/integration-tests/tests/truncation_tests.rs` (+1 -1) </details> ### 📄 Description following #1933 making the trait non mut so usage of it doesn't need Mutex --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>