[PR #1999] [MERGED] Ignore invalid search domains #2746

New issue

Closed

opened 2026-03-16 11:06:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:06:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1999
Author: @Jake-Shadle
Created: 8/15/2023
Status: ✅ Merged
Merged: 8/21/2023
Merged by: @djc

Base: main ← Head: main

📝 Commits (1)

f8dc386 Ignore invalid search domains

📊 Changes

1 file changed (+28 additions, -0 deletions)

View changed files

📝 crates/resolver/src/system_conf/unix.rs (+28 -0)

📄 Description

This just skips the presence of the invalid -- in search only, not sure if can ever be present in other sections of a resolv.conf. Added a test that uses the same systemd-resolv based config that my local machine has which caused me to open #1985.

Resolves: #1985

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1999 **Author:** [@Jake-Shadle](https://github.com/Jake-Shadle) **Created:** 8/15/2023 **Status:** ✅ Merged **Merged:** 8/21/2023 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`f8dc386`](https://github.com/hickory-dns/hickory-dns/commit/f8dc386d957aa7c5c91eedc8aa94a64fa72b430a) Ignore invalid search domains ### 📊 Changes **1 file changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/system_conf/unix.rs` (+28 -0) </details> ### 📄 Description This just skips the presence of the invalid `--` in search only, not sure if can ever be present in other sections of a resolv.conf. Added a test that uses the same systemd-resolv based config that my local machine has which caused me to open #1985. Resolves: #1985 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>