[PR #1964] [MERGED] proto: avoid panicking in parse_time() #2726

New issue

Closed

opened 2026-03-16 11:04:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:04:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1964
Author: @djc
Created: 6/9/2023
Status: ✅ Merged
Merged: 6/9/2023
Merged by: @bluejekyll

Base: main ← Head: parse-time-error

📝 Commits (1)

99062b2 proto: avoid panicking in parse_time()

📊 Changes

1 file changed (+45 additions, -40 deletions)

View changed files

📝 crates/proto/src/serialize/txt/zone.rs (+45 -40)

📄 Description

Substantially rewrite parse_time() to avoid duplication and make sure overflows result in an error.

Fixes #1963.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1964 **Author:** [@djc](https://github.com/djc) **Created:** 6/9/2023 **Status:** ✅ Merged **Merged:** 6/9/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `parse-time-error` --- ### 📝 Commits (1) - [`99062b2`](https://github.com/hickory-dns/hickory-dns/commit/99062b21a75057c653b52b9250861aa8b46c157a) proto: avoid panicking in parse_time() ### 📊 Changes **1 file changed** (+45 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/serialize/txt/zone.rs` (+45 -40) </details> ### 📄 Description Substantially rewrite `parse_time()` to avoid duplication and make sure overflows result in an error. Fixes #1963. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>