[PR #1945] [MERGED] Make RData::read() API public #2710

New issue

Closed

opened 2026-03-16 11:04:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:04:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1945
Author: @djc
Created: 5/25/2023
Status: ✅ Merged
Merged: 5/29/2023
Merged by: @bluejekyll

Base: main ← Head: rdata-read

📝 Commits (1)

f6363d5 Make RData::read() API public

📊 Changes

2 files changed (+3 additions, -7 deletions)

View changed files

📝 crates/proto/src/rr/record_data.rs (+2 -2)
📝 crates/proto/src/rr/resource.rs (+1 -5)

📄 Description

RData::read() used to be public before #1770. We were using it at work to retrieve binary-encoded record data from Redis for our DNS servers. As far as I can tell, there's no good alternative in the 0.23.0-alpha.1 API -- Record<RData> implements BinEncodable but it also wants to decode things like type and TTL.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1945 **Author:** [@djc](https://github.com/djc) **Created:** 5/25/2023 **Status:** ✅ Merged **Merged:** 5/29/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `rdata-read` --- ### 📝 Commits (1) - [`f6363d5`](https://github.com/hickory-dns/hickory-dns/commit/f6363d53c1f687ca0be1efed3f90376e4a9be54d) Make RData::read() API public ### 📊 Changes **2 files changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/record_data.rs` (+2 -2) 📝 `crates/proto/src/rr/resource.rs` (+1 -5) </details> ### 📄 Description [`RData::read()`](https://github.com/bluejekyll/trust-dns/pull/1770/files#diff-ffc7b721f2150b0b8af3b8dec18dadc84ea33a31b87ac23a601510a2fccf52d0L706) used to be public before #1770. We were using it at work to retrieve binary-encoded record data from Redis for our DNS servers. As far as I can tell, there's no good alternative in the 0.23.0-alpha.1 API -- `Record<RData>` implements `BinEncodable` but it also wants to decode things like type and TTL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>