[PR #1931] [MERGED] resolver: Fix minimal tokio version requirement #2703

New issue

Closed

opened 2026-03-16 11:03:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:03:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1931
Author: @Gelbpunkt
Created: 5/13/2023
Status: ✅ Merged
Merged: 5/15/2023
Merged by: @djc

Base: main ← Head: tokio-version

📝 Commits (1)

c6a8116 resolver: Fix minimal tokio version requirement

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Cargo.toml (+1 -1)

📄 Description

The resolver uses JoinSet, which was only stabilized in tokio 1.21. This fixes the cargo minimal-versions check issues in dependent crates (see a failed run here). You might be interested in checking this in your CI as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1931 **Author:** [@Gelbpunkt](https://github.com/Gelbpunkt) **Created:** 5/13/2023 **Status:** ✅ Merged **Merged:** 5/15/2023 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `tokio-version` --- ### 📝 Commits (1) - [`c6a8116`](https://github.com/hickory-dns/hickory-dns/commit/c6a8116cf9c25bcd0890218a36a85ac07b257cb0) resolver: Fix minimal tokio version requirement ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -1) </details> ### 📄 Description The resolver uses `JoinSet`, which was only stabilized in tokio 1.21. This fixes the `cargo minimal-versions` check issues in dependent crates (see a failed run [here](https://github.com/Gelbpunkt/hyper-trust-dns/actions/runs/4961062221/jobs/8878778776?pr=5)). You might be interested in checking this in your CI as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>