[PR #1900] [MERGED] Fix: invalid benchmark #2681

New issue

Closed

opened 2026-03-16 11:02:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:02:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1900
Author: @XOR-op
Created: 3/5/2023
Status: ✅ Merged
Merged: 3/6/2023
Merged by: @djc

Base: main ← Head: main

📝 Commits (1)

4cdae10 fix: stale benchmark

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 bin/benches/comparison_benches.rs (+2 -2)

📄 Description

When users need to test the performance of resolver, they need to run

RUSTFLAGS="--cfg nightly" cargo +nightly bench --bench=comparison_benches

However, the commit 0643ee didn't clean the code. Users will fail the benchmark because the bench code invokes named, while it has been renamed to trust-dns. This commit fixes the bug.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1900 **Author:** [@XOR-op](https://github.com/XOR-op) **Created:** 3/5/2023 **Status:** ✅ Merged **Merged:** 3/6/2023 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`4cdae10`](https://github.com/hickory-dns/hickory-dns/commit/4cdae104567b10b6139445872e2eea75965beee6) fix: stale benchmark ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bin/benches/comparison_benches.rs` (+2 -2) </details> ### 📄 Description When users need to test the performance of resolver, they need to run ```bash RUSTFLAGS="--cfg nightly" cargo +nightly bench --bench=comparison_benches ``` However, the commit [0643ee](https://github.com/bluejekyll/trust-dns/blob/0643ee529ab3f1b25210f2f24e83a36b13f7889e/bin/Cargo.toml) didn't clean the code. Users will fail the benchmark because the bench code invokes `named`, while it has been renamed to `trust-dns`. This commit fixes the bug. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>