[PR #1883] [CLOSED] Revert "authority: parse with default record class IN." #2672

New issue

Closed

opened 2026-03-16 11:01:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:01:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1883
Author: @bluejekyll
Created: 1/17/2023
Status: ❌ Closed

Base: main ← Head: revert-1874-cpu-zone-parse-default-class

📝 Commits (3)

b4934a1 Revert "tests: add file authority test for default IN."
574caaf Revert "client: unit test default zone class."
b5cf205 Revert "authority: parse with default record class IN."

📊 Changes

4 files changed (+1 additions, -64 deletions)

View changed files

📝 crates/client/src/serialize/txt/zone.rs (+0 -33)
📝 crates/server/src/store/file/authority.rs (+1 -2)
📝 crates/server/tests/store_file_tests.rs (+0 -16)
➖ tests/test-data/test_configs/default/implicitclass.zone (+0 -13)

📄 Description

Reverts bluejekyll/trust-dns#1874

Sorry, I misunderstood @djc's question in #1874, I'm going to revert and we can continue that conversation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1883 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/17/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `revert-1874-cpu-zone-parse-default-class` --- ### 📝 Commits (3) - [`b4934a1`](https://github.com/hickory-dns/hickory-dns/commit/b4934a1410101fb23d23b4ec089e57c9e22f7ece) Revert "tests: add file authority test for default IN." - [`574caaf`](https://github.com/hickory-dns/hickory-dns/commit/574caaf892230eef82d9301809677192f15cdeb8) Revert "client: unit test default zone class." - [`b5cf205`](https://github.com/hickory-dns/hickory-dns/commit/b5cf2052f6075e0118e5f5d2c183b1e13644c3f4) Revert "authority: parse with default record class IN." ### 📊 Changes **4 files changed** (+1 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/zone.rs` (+0 -33) 📝 `crates/server/src/store/file/authority.rs` (+1 -2) 📝 `crates/server/tests/store_file_tests.rs` (+0 -16) ➖ `tests/test-data/test_configs/default/implicitclass.zone` (+0 -13) </details> ### 📄 Description Reverts bluejekyll/trust-dns#1874 Sorry, I misunderstood @djc's question in #1874, I'm going to revert and we can continue that conversation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>