[PR #1873] [MERGED] project: remove refs. to removed 'named' binary #2662

New issue

Closed

opened 2026-03-16 11:01:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:01:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1873
Author: @cpu
Created: 1/7/2023
Status: ✅ Merged
Merged: 1/11/2023
Merged by: @bluejekyll

Base: main ← Head: cpu-1859-follow-ups

📝 Commits (7)

90c635b bin: remove 'named' binary refs
f11d455 crates: remove 'named' binary refs
77cbc4c bin: remove 'named' binary refs
57051b5 README: remove 'named' binary refs
3b18151 ARCH: remove 'named' binary refs
a76a292 bin: named.rs -> trust-dns.rs
6c2f830 tests: named_test_configs -> test_configs

📊 Changes

60 files changed (+84 additions, -90 deletions)

View changed files

📝 ARCHITECTURE.md (+1 -1)
📝 README.md (+6 -6)
📝 bin/Cargo.toml (+1 -1)
📝 bin/README.md (+2 -2)
📝 bin/benches/bind_conf/example.conf (+7 -7)
📝 bin/benches/comparison_benches.rs (+2 -5)
📝 bin/src/trust-dns.rs (+3 -3)
📝 bin/tests/named_https_tests.rs (+1 -1)
📝 bin/tests/named_openssl_tests.rs (+1 -1)
📝 bin/tests/named_quic_tests.rs (+1 -1)
📝 bin/tests/named_rustls_tests.rs (+1 -1)
📝 bin/tests/named_test_rsa_dnssec.rs (+14 -15)
📝 bin/tests/server_harness/mod.rs (+2 -2)
📝 crates/server/README.md (+1 -1)
📝 crates/server/src/store/file/authority.rs (+2 -2)
📝 crates/server/tests/authority_battery/basic.rs (+1 -1)
📝 crates/server/tests/authority_battery/dnssec.rs (+5 -5)
📝 crates/server/tests/authority_battery/dynamic_update.rs (+5 -5)
📝 crates/server/tests/config_tests.rs (+2 -2)
📝 crates/server/tests/store_file_tests.rs (+2 -4)

...and 40 more files

📄 Description

Hi folks,

I noticed the README references a named binary that was removed in https://github.com/bluejekyll/trust-dns/pull/1859 in favour of using trust-dns. This branch is my attempt to clean up a few remaining references like this.

I've split each edit into its own commit in case you prefer some of these remain as-is. I think the README update is the most important of the set.

I chose not to rename bin/src/named.rs, or to update the name of test configs/directories (e.g. tests/test-data/named_test_configs/). If you think those should be renamed as well, I could roll that in :-) Edit: we included these changes too.

Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1873 **Author:** [@cpu](https://github.com/cpu) **Created:** 1/7/2023 **Status:** ✅ Merged **Merged:** 1/11/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `cpu-1859-follow-ups` --- ### 📝 Commits (7) - [`90c635b`](https://github.com/hickory-dns/hickory-dns/commit/90c635b7bb53cb8be924e3c86db7c8d2293c0ea2) bin: remove 'named' binary refs - [`f11d455`](https://github.com/hickory-dns/hickory-dns/commit/f11d455c1cf8deb2a33a9673ed519f2d9e6438ab) crates: remove 'named' binary refs - [`77cbc4c`](https://github.com/hickory-dns/hickory-dns/commit/77cbc4c5dd89338a1b16c653b5483e8b697508c4) bin: remove 'named' binary refs - [`57051b5`](https://github.com/hickory-dns/hickory-dns/commit/57051b5753f01f3d4c312712a329165e72de20a4) README: remove 'named' binary refs - [`3b18151`](https://github.com/hickory-dns/hickory-dns/commit/3b181510c2bbff1f77da0348080d12a0d220f43a) ARCH: remove 'named' binary refs - [`a76a292`](https://github.com/hickory-dns/hickory-dns/commit/a76a2929427387353fa070efa73e03dcf1c6c866) bin: named.rs -> trust-dns.rs - [`6c2f830`](https://github.com/hickory-dns/hickory-dns/commit/6c2f83070735d0d281f0d245498fbafc82e063e3) tests: named_test_configs -> test_configs ### 📊 Changes **60 files changed** (+84 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `ARCHITECTURE.md` (+1 -1) 📝 `README.md` (+6 -6) 📝 `bin/Cargo.toml` (+1 -1) 📝 `bin/README.md` (+2 -2) 📝 `bin/benches/bind_conf/example.conf` (+7 -7) 📝 `bin/benches/comparison_benches.rs` (+2 -5) 📝 `bin/src/trust-dns.rs` (+3 -3) 📝 `bin/tests/named_https_tests.rs` (+1 -1) 📝 `bin/tests/named_openssl_tests.rs` (+1 -1) 📝 `bin/tests/named_quic_tests.rs` (+1 -1) 📝 `bin/tests/named_rustls_tests.rs` (+1 -1) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+14 -15) 📝 `bin/tests/server_harness/mod.rs` (+2 -2) 📝 `crates/server/README.md` (+1 -1) 📝 `crates/server/src/store/file/authority.rs` (+2 -2) 📝 `crates/server/tests/authority_battery/basic.rs` (+1 -1) 📝 `crates/server/tests/authority_battery/dnssec.rs` (+5 -5) 📝 `crates/server/tests/authority_battery/dynamic_update.rs` (+5 -5) 📝 `crates/server/tests/config_tests.rs` (+2 -2) 📝 `crates/server/tests/store_file_tests.rs` (+2 -4) _...and 40 more files_ </details> ### 📄 Description Hi folks, I noticed the README references a `named` binary that was removed in https://github.com/bluejekyll/trust-dns/pull/1859 in favour of using `trust-dns`. This branch is my attempt to clean up a few remaining references like this. I've split each edit into its own commit in case you prefer some of these remain as-is. I think the README update is the most important of the set. ~I chose **not** to rename `bin/src/named.rs`, or to update the name of test configs/directories (e.g. `tests/test-data/named_test_configs/`). If you think those should be renamed as well, I could roll that in :-)~ Edit: we included these changes too. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>