[PR #1861] [MERGED] Don't retry authoritative NOERROR with an empty set, from trusted resolvers #2655

New issue

Closed

opened 2026-03-16 11:01:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:01:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1861
Author: @jeff-hiner
Created: 12/15/2022
Status: ✅ Merged
Merged: 12/21/2022
Merged by: @djc

Base: main ← Head: trust_noerror

📝 Commits (1)

73438fa Don't retry NOERROR with an empty set, from trusted resolvers

📊 Changes

12 files changed (+130 additions, -58 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+2 -2)
📝 crates/resolver/src/config.rs (+28 -14)
📝 crates/resolver/src/error.rs (+6 -2)
📝 crates/resolver/src/name_server/name_server.rs (+6 -6)
📝 crates/resolver/src/name_server/name_server_pool.rs (+3 -3)
📝 crates/resolver/src/system_conf/unix.rs (+4 -4)
📝 crates/resolver/src/system_conf/windows.rs (+2 -2)
📝 crates/server/src/store/recursor/authority.rs (+2 -2)
📝 tests/integration-tests/src/mock_client.rs (+6 -1)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+67 -18)
📝 util/src/recurse.rs (+2 -2)
📝 util/src/resolve.rs (+2 -2)

📄 Description

Resolves https://github.com/bluejekyll/trust-dns/issues/1860

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1861 **Author:** [@jeff-hiner](https://github.com/jeff-hiner) **Created:** 12/15/2022 **Status:** ✅ Merged **Merged:** 12/21/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `trust_noerror` --- ### 📝 Commits (1) - [`73438fa`](https://github.com/hickory-dns/hickory-dns/commit/73438fa5f247543899822dd6d8539556c13a2bde) Don't retry NOERROR with an empty set, from trusted resolvers ### 📊 Changes **12 files changed** (+130 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+2 -2) 📝 `crates/resolver/src/config.rs` (+28 -14) 📝 `crates/resolver/src/error.rs` (+6 -2) 📝 `crates/resolver/src/name_server/name_server.rs` (+6 -6) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+3 -3) 📝 `crates/resolver/src/system_conf/unix.rs` (+4 -4) 📝 `crates/resolver/src/system_conf/windows.rs` (+2 -2) 📝 `crates/server/src/store/recursor/authority.rs` (+2 -2) 📝 `tests/integration-tests/src/mock_client.rs` (+6 -1) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+67 -18) 📝 `util/src/recurse.rs` (+2 -2) 📝 `util/src/resolve.rs` (+2 -2) </details> ### 📄 Description Resolves https://github.com/bluejekyll/trust-dns/issues/1860 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>