[PR #1794] [MERGED] Improve CAA rdata display #2612

New issue

Closed

opened 2026-03-16 10:47:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:47:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1794
Author: @wuerges
Created: 10/11/2022
Status: ✅ Merged
Merged: 10/29/2022
Merged by: @djc

Base: main ← Head: improve-caa-records-display

📝 Commits (5)

5e469fd Improve CAA rdata display
71ab69f add test with empty domain
1e8ec7c moved tests to parser
1b68479 Output `` instead of ; for empty issue property.
1299d28 return error for non utf8 unknown

📊 Changes

2 files changed (+139 additions, -15 deletions)

View changed files

📝 crates/client/src/serialize/txt/rdata_parsers/caa.rs (+75 -0)
📝 crates/proto/src/rr/rdata/caa.rs (+64 -15)

📄 Description

This PR improves the CAA RData Display trait.

It adds the examples from the RFC 6844 as test cases and fixes the fmt::Display for the Value struct.

Shows the true issuer_critical flag as 128 instead of 1.
- Ideally, the flag should have been stored as a u8.
Fixes how the ; separator is handled.
Shows Value::Unknown as a string, if it is a valid UTF8 string.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1794 **Author:** [@wuerges](https://github.com/wuerges) **Created:** 10/11/2022 **Status:** ✅ Merged **Merged:** 10/29/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `improve-caa-records-display` --- ### 📝 Commits (5) - [`5e469fd`](https://github.com/hickory-dns/hickory-dns/commit/5e469fda3ef7f9d1e6a36f87119744ac57028281) Improve CAA rdata display - [`71ab69f`](https://github.com/hickory-dns/hickory-dns/commit/71ab69fd51e9595d56504a41f000676bcb5d2754) add test with empty domain - [`1e8ec7c`](https://github.com/hickory-dns/hickory-dns/commit/1e8ec7cd59937bab53c53fd84274bbf5f8798baa) moved tests to parser - [`1b68479`](https://github.com/hickory-dns/hickory-dns/commit/1b684790146f500563f00e659d5f45ce725eb4ae) Output `` instead of `;` for empty issue property. - [`1299d28`](https://github.com/hickory-dns/hickory-dns/commit/1299d285e6f64a82d1068c7ea7ff4e26f46991ef) return error for non utf8 unknown ### 📊 Changes **2 files changed** (+139 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/rdata_parsers/caa.rs` (+75 -0) 📝 `crates/proto/src/rr/rdata/caa.rs` (+64 -15) </details> ### 📄 Description This PR improves the CAA RData Display trait. It adds the examples from the RFC 6844 as test cases and fixes the `fmt::Display` for the `Value` struct. - Shows the `true` `issuer_critical` flag as `128` instead of `1`. - Ideally, the flag should have been stored as a `u8`. - Fixes how the `;` separator is handled. - Shows `Value::Unknown` as a string, if it is a valid UTF8 string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>