[PR #1791] [MERGED] Port to clap4 #2611

New issue

Closed

opened 2026-03-16 10:47:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:47:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1791
Author: @darnuria
Created: 10/8/2022
Status: ✅ Merged
Merged: 11/10/2022
Merged by: @bluejekyll

Base: main ← Head: port/clap4

📝 Commits (6)

cea9de0 Bump clap from 3.2.18 to 4.0.18
eb300be Port commands line interfaces to clap 4.
0a278a1 Port named CLI to use clap derive API
60a6d16 Port dnskey_to_pem to clap4 derive API.
cff91ac Improve error message if key-file not opennable.
03dc5fa Port pem_to_public_dnskey to clap4 derive API.

📊 Changes

9 files changed (+164 additions, -226 deletions)

View changed files

📝 Cargo.lock (+6 -14)
📝 bin/Cargo.toml (+5 -1)
📝 bin/src/named.rs (+62 -128)
📝 util/Cargo.toml (+1 -1)
📝 util/src/bind_dnskey_to_pem.rs (+42 -33)
📝 util/src/dns.rs (+5 -5)
📝 util/src/pem_to_public_dnskey.rs (+39 -32)
📝 util/src/recurse.rs (+2 -6)
📝 util/src/resolve.rs (+2 -6)

📄 Description

Based on initial PR by depBot #1786 some breaking change, still an early draft.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1791 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 10/8/2022 **Status:** ✅ Merged **Merged:** 11/10/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `port/clap4` --- ### 📝 Commits (6) - [`cea9de0`](https://github.com/hickory-dns/hickory-dns/commit/cea9de03c183e71d11704efc368d2c98882b80ce) Bump clap from 3.2.18 to 4.0.18 - [`eb300be`](https://github.com/hickory-dns/hickory-dns/commit/eb300be55731f72d6ff76393c0bae52a289a8c4f) Port commands line interfaces to clap 4. - [`0a278a1`](https://github.com/hickory-dns/hickory-dns/commit/0a278a1f3d8955d3a7e9247f5e5447eea5b0607d) Port named CLI to use clap derive API - [`60a6d16`](https://github.com/hickory-dns/hickory-dns/commit/60a6d1696c93adec0aa24bb35e3f8e2acf125e38) Port dnskey_to_pem to clap4 derive API. - [`cff91ac`](https://github.com/hickory-dns/hickory-dns/commit/cff91acfb702f0aeb97cd3f07f7b4c38d1db377f) Improve error message if key-file not opennable. - [`03dc5fa`](https://github.com/hickory-dns/hickory-dns/commit/03dc5fa6645bfb97015600e78dd1aff803670f68) Port pem_to_public_dnskey to clap4 derive API. ### 📊 Changes **9 files changed** (+164 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+6 -14) 📝 `bin/Cargo.toml` (+5 -1) 📝 `bin/src/named.rs` (+62 -128) 📝 `util/Cargo.toml` (+1 -1) 📝 `util/src/bind_dnskey_to_pem.rs` (+42 -33) 📝 `util/src/dns.rs` (+5 -5) 📝 `util/src/pem_to_public_dnskey.rs` (+39 -32) 📝 `util/src/recurse.rs` (+2 -6) 📝 `util/src/resolve.rs` (+2 -6) </details> ### 📄 Description Based on initial PR by depBot #1786 some breaking change, still an early draft. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>