[PR #1777] [MERGED] Fix bench errors in rust-analyzer #2596

New issue

Closed

opened 2026-03-16 10:44:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:44:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1777
Author: @jeff-hiner
Created: 9/13/2022
Status: ✅ Merged
Merged: 9/13/2022
Merged by: @djc

Base: main ← Head: fix_bench

📝 Commits (1)

56120ae Fix bench errors in rust-analyzer

📊 Changes

4 files changed (+4 additions, -0 deletions)

View changed files

📝 bin/benches/comparison_benches.rs (+1 -0)
📝 crates/client/benches/lower_name_benches.rs (+1 -0)
📝 crates/proto/benches/lib.rs (+1 -0)
📝 crates/proto/benches/name_benches.rs (+1 -0)

📄 Description

#![feature(test)] is nightly, but rust-analyzer sees files in benches and still tries to build them. This causes spurious errors in IDEs such as VSCode. Marking each bench file as nightly-only fixes this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1777 **Author:** [@jeff-hiner](https://github.com/jeff-hiner) **Created:** 9/13/2022 **Status:** ✅ Merged **Merged:** 9/13/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `fix_bench` --- ### 📝 Commits (1) - [`56120ae`](https://github.com/hickory-dns/hickory-dns/commit/56120aefacfb2d57ee389b9cf39d67aef448324a) Fix bench errors in rust-analyzer ### 📊 Changes **4 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `bin/benches/comparison_benches.rs` (+1 -0) 📝 `crates/client/benches/lower_name_benches.rs` (+1 -0) 📝 `crates/proto/benches/lib.rs` (+1 -0) 📝 `crates/proto/benches/name_benches.rs` (+1 -0) </details> ### 📄 Description `#![feature(test)]` is nightly, but rust-analyzer sees files in `benches` and still tries to build them. This causes spurious errors in IDEs such as VSCode. Marking each bench file as nightly-only fixes this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>