[PR #1758] [MERGED] Parser panic to result #2582

New issue

Closed

opened 2026-03-16 10:43:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:43:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1758
Author: @darnuria
Created: 8/7/2022
Status: ✅ Merged
Merged: 8/8/2022
Merged by: @djc

Base: main ← Head: parser_panic_to_result

📝 Commits (2)

8ffc6a9 Convers unwrap in csync::Parse to Result + ?.
579fab9 Zone Parser::flush_record change panic to Result.

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 crates/client/src/serialize/txt/rdata_parsers/csync.rs (+1 -1)
📝 crates/client/src/serialize/txt/zone.rs (+2 -1)

📄 Description

An other patch about trying to avoid unwrap/panic no problem for rolling up or squashing commits.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1758 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 8/7/2022 **Status:** ✅ Merged **Merged:** 8/8/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `parser_panic_to_result` --- ### 📝 Commits (2) - [`8ffc6a9`](https://github.com/hickory-dns/hickory-dns/commit/8ffc6a9c78176ef9e4598d80574a6b612026a9ca) Convers unwrap in csync::Parse to Result + ?. - [`579fab9`](https://github.com/hickory-dns/hickory-dns/commit/579fab982b7d209907c1539df790e45f1f73ce69) Zone Parser::flush_record change panic to Result. ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/rdata_parsers/csync.rs` (+1 -1) 📝 `crates/client/src/serialize/txt/zone.rs` (+2 -1) </details> ### 📄 Description An other patch about trying to avoid `unwrap`/`panic` no problem for rolling up or squashing commits. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>