[GH-ISSUE #639] Minimum Rust Version policy? #258

Open
opened 2026-03-07 23:04:15 +03:00 by kerem · 2 comments
Owner

Originally created by @seanmonstar on GitHub (Dec 17, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/639

Does trust-dns have a minimum rust version policy? Such as keeping the same minimum Rust in patch versions, or something? I see a commented out minimum Rust in the CI, but I'm not sure what is the current minimum version.

For reference, I'm looking into changing the DNS resolver in reqwest, and noticed it doesn't seem to compile on Rust v1.29. Is that something you'd like to support? Or should I consider upgrading reqwest in its next breaking change?

Originally created by @seanmonstar on GitHub (Dec 17, 2018). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/639 Does trust-dns have a minimum rust version policy? Such as keeping the same minimum Rust in patch versions, or something? I see [a commented out minimum Rust in the CI](https://github.com/bluejekyll/trust-dns/blob/master/.travis.yml#L88-L89), but I'm not sure what is the current minimum version. For reference, I'm looking into [changing the DNS resolver in reqwest](https://github.com/seanmonstar/reqwest/pull/401), and noticed it doesn't seem to compile on Rust v1.29. Is that something you'd like to support? Or should I consider upgrading reqwest in its next breaking change?
Author
Owner

@bluejekyll commented on GitHub (Dec 18, 2018):

I have a vague desire to, but it’s not something I’ve been focused on. I think we could support 1.29 pretty easily at this point. If it helps in your adopting it, I’d be happy to keep a 1.29 build checked in CI.

After Futures stabilize in std, I guess we’ll need some way to detect 1.3x, as I’d want to support that API.

<!-- gh-comment-id:448068311 --> @bluejekyll commented on GitHub (Dec 18, 2018): I have a vague desire to, but it’s not something I’ve been focused on. I think we could support 1.29 pretty easily at this point. If it helps in your adopting it, I’d be happy to keep a 1.29 build checked in CI. After Futures stabilize in std, I guess we’ll need some way to detect 1.3x, as I’d want to support that API.
Author
Owner

@bluejekyll commented on GitHub (Dec 18, 2018):

I will say, the last time I spoke to @briansmith about this (trust-dns uses ring and rustls) he didn’t have an intention of supporting previous versions. That might be part of the reason why that CI validation was disabled.

<!-- gh-comment-id:448072743 --> @bluejekyll commented on GitHub (Dec 18, 2018): I will say, the last time I spoke to @briansmith about this (trust-dns uses ring and rustls) he didn’t have an intention of supporting previous versions. That might be part of the reason why that CI validation was disabled.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#258
No description provided.