[PR #1757] [MERGED] Avoid 3 unwrap() call inc Parser::flush_record. #2576

Closed
opened 2026-03-16 10:28:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1757
Author: @darnuria
Created: 8/7/2022
Status: Merged
Merged: 8/7/2022
Merged by: @djc

Base: mainHead: small_cleanup_zones_qtype


📝 Commits (1)

  • ee8af8e Avoid 3 unwrap() call inc Parser::flush_record.

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 crates/client/src/serialize/txt/zone.rs (+7 -6)

📄 Description

Some unwrap cleaning passed the test, it's a feel-lucky change if any additional test is needed todo/write please tel me. :)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1757 **Author:** [@darnuria](https://github.com/darnuria) **Created:** 8/7/2022 **Status:** ✅ Merged **Merged:** 8/7/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `small_cleanup_zones_qtype` --- ### 📝 Commits (1) - [`ee8af8e`](https://github.com/hickory-dns/hickory-dns/commit/ee8af8eca8398cdb3e15f3e01b06b9bb4dfa5351) Avoid 3 unwrap() call inc Parser::flush_record. ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/zone.rs` (+7 -6) </details> ### 📄 Description Some unwrap cleaning passed the test, it's a feel-lucky change if any additional test is needed todo/write please tel me. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 10:28:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2576
No description provided.