[PR #1742] [MERGED] Pass DnsRequestOptions to DNSSEC validating routines #2562

New issue

Closed

opened 2026-03-16 10:11:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:11:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1742
Author: @wiktor-k
Created: 7/19/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @djc

Base: main ← Head: fix-dns-req-opts

📝 Commits (1)

4b4e520 Pass DnsRequestOptions to DNSSEC validating routines

📊 Changes

1 file changed (+17 additions, -11 deletions)

View changed files

📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+17 -11)

📄 Description

Hello,

This PR fixes the issue reported in #1735 and makes sure that the DnsRequestOptions that the client specifies are being forwarded to the DNSSEC validating functions.

The change is basically grabbing a copy of the options (because request is passed by value to send the original options cannot be used) and then adding the options parameter to validate_* functions and using that instead of DnsRequestOptions::default(). The additional parameter should not affect public API since all these functions are not marked pub.

When this PR gets merged I'll follow up with the "configurable max_request_depth" PR that doesn't make sense if the options are not being forwarded in the first place :).

Suggestions welcome! 👋

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1742 **Author:** [@wiktor-k](https://github.com/wiktor-k) **Created:** 7/19/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `fix-dns-req-opts` --- ### 📝 Commits (1) - [`4b4e520`](https://github.com/hickory-dns/hickory-dns/commit/4b4e520a0a42cdb46f3002e52b6bfbac6e26057e) Pass DnsRequestOptions to DNSSEC validating routines ### 📊 Changes **1 file changed** (+17 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+17 -11) </details> ### 📄 Description Hello, This PR fixes the issue reported in #1735 and makes sure that the `DnsRequestOptions` that the client specifies are being forwarded to the DNSSEC validating functions. The change is basically grabbing a copy of the options (because request is passed by value to `send` the original options cannot be used) and then adding the options parameter to `validate_*` functions and using that instead of `DnsRequestOptions::default()`. The additional parameter should not affect public API since all these functions are not marked `pub`. When this PR gets merged I'll follow up with the "configurable max_request_depth" PR that doesn't make sense if the options are not being forwarded in the first place :). Suggestions welcome! :wave: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>