[PR #1729] [MERGED] Mark ForwardLookup as public #2546

New issue

Closed

opened 2026-03-16 10:07:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:07:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1729
Author: @chotchki
Created: 6/25/2022
Status: ✅ Merged
Merged: 6/28/2022
Merged by: @bluejekyll

Base: main ← Head: patch-v2

📝 Commits (1)

7ea11d6 Mark ForwardLookup as public

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 crates/server/src/store/forwarder/authority.rs (+4 -1)
📝 crates/server/src/store/forwarder/mod.rs (+1 -0)

📄 Description

I am trying to implement a wrapper around ForwardAuthority so I can intercept for rewriting/auditing what a dns forwarder produces. However implementing a wrapper is extremely challenging without ForwardLookup and its contents being public.

As noted in the other branch I also added documentation to the struct as well.

Recreation of pull request #1727 with a clean git history. I also added pub to ResolverLookup that was required to construct it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1729 **Author:** [@chotchki](https://github.com/chotchki) **Created:** 6/25/2022 **Status:** ✅ Merged **Merged:** 6/28/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `patch-v2` --- ### 📝 Commits (1) - [`7ea11d6`](https://github.com/hickory-dns/hickory-dns/commit/7ea11d6ca5ad8954c58b15f86129da487e68e472) Mark ForwardLookup as public ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/forwarder/authority.rs` (+4 -1) 📝 `crates/server/src/store/forwarder/mod.rs` (+1 -0) </details> ### 📄 Description I am trying to implement a wrapper around ForwardAuthority so I can intercept for rewriting/auditing what a dns forwarder produces. However implementing a wrapper is extremely challenging without ForwardLookup and its contents being public. As noted in the other branch I also added documentation to the struct as well. Recreation of pull request #1727 with a clean git history. I also added pub to ResolverLookup that was required to construct it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>