[PR #1715] [MERGED] Use `u16::*_be_bytes` represent length field #2544

New issue

Closed

opened 2026-03-16 10:07:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:07:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1715
Author: @msoxzw
Created: 6/4/2022
Status: ✅ Merged
Merged: 6/4/2022
Merged by: @bluejekyll

Base: main ← Head: length-field

📝 Commits (2)

c510289 represent length field in big-endian in DoQ
c001031 prefer u16::*_be_bytes to self-implementation

📊 Changes

2 files changed (+4 additions, -8 deletions)

View changed files

📝 crates/proto/src/quic/quic_stream.rs (+2 -2)
📝 crates/proto/src/tcp/tcp_stream.rs (+2 -6)

📄 Description

In DoQ packet, portable code should represent length filed in big endian rather than native endian.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1715 **Author:** [@msoxzw](https://github.com/msoxzw) **Created:** 6/4/2022 **Status:** ✅ Merged **Merged:** 6/4/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `length-field` --- ### 📝 Commits (2) - [`c510289`](https://github.com/hickory-dns/hickory-dns/commit/c5102899117a3d4197f9a02e5164a4bbb80edb45) represent length field in big-endian in DoQ - [`c001031`](https://github.com/hickory-dns/hickory-dns/commit/c00103179b81a9f540787e31f1fa1a466cff399b) prefer `u16::*_be_bytes` to self-implementation ### 📊 Changes **2 files changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/quic/quic_stream.rs` (+2 -2) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+2 -6) </details> ### 📄 Description In DoQ packet, portable code should represent length filed in big endian rather than native endian. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>