[PR #1706] [MERGED] Cleanup Erikh's tracing conversion #2539

New issue

Closed

opened 2026-03-16 10:06:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:06:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1706
Author: @bluejekyll
Created: 5/3/2022
Status: ✅ Merged
Merged: 5/9/2022
Merged by: @bluejekyll

Base: main ← Head: erikh-tracing

📝 Commits (7)

346909f Move log to tracing package
f77c222 Move util subpackage to tracing package
6fd2456 Restore enabled checks with level_enabled! macro
4981b8d cleanup transition to tracing
6509957 updates from PR review for tracing
6772fb0 update Windows OpenSSL version to 1_1_1o
57c5b1f rebase to main for tracing

📊 Changes

76 files changed (+357 additions, -253 deletions)

View changed files

📝 Cargo.lock (+101 -38)
📝 Makefile.toml (+1 -1)
📝 bin/Cargo.toml (+2 -3)
📝 bin/src/named.rs (+77 -55)
📝 bin/tests/named_https_tests.rs (+0 -3)
📝 bin/tests/named_openssl_tests.rs (+0 -3)
📝 bin/tests/named_quic_tests.rs (+0 -3)
📝 bin/tests/named_rustls_tests.rs (+0 -3)
📝 bin/tests/named_test_rsa_dnssec.rs (+2 -4)
📝 bin/tests/named_tests.rs (+0 -3)
📝 bin/tests/server_harness/mod.rs (+1 -0)
📝 crates/client/Cargo.toml (+2 -1)
📝 crates/client/src/client/async_client.rs (+1 -1)
📝 crates/client/src/rr/dnssec/signer.rs (+3 -1)
📝 crates/client/src/rr/dnssec/tsig.rs (+3 -1)
📝 crates/client/src/serialize/txt/rdata_parsers/caa.rs (+1 -1)
📝 crates/proto/Cargo.toml (+2 -2)
📝 crates/proto/src/https/https_client_stream.rs (+1 -1)
📝 crates/proto/src/https/https_server.rs (+1 -1)
📝 crates/proto/src/https/request.rs (+1 -1)

...and 56 more files

📄 Description

@erikh, I hope you don't mind, I took your changes and made the last few changes necessary.

@djc, Do you think this would require a major bump to the version? I think the log-line structure for the named binary is consistent with it's original output if not identical (it's pretty close).

@hawkw, could I bother you for your opinion on this?

closes: #1667

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1706 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 5/3/2022 **Status:** ✅ Merged **Merged:** 5/9/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `erikh-tracing` --- ### 📝 Commits (7) - [`346909f`](https://github.com/hickory-dns/hickory-dns/commit/346909f659d9f94494e750d22d81107a5aaf4c07) Move log to tracing package - [`f77c222`](https://github.com/hickory-dns/hickory-dns/commit/f77c2227379033588bd8cc800394dccf195d50a6) Move util subpackage to tracing package - [`6fd2456`](https://github.com/hickory-dns/hickory-dns/commit/6fd245633e4d7a474d585af05f693636fcde437a) Restore enabled checks with level_enabled! macro - [`4981b8d`](https://github.com/hickory-dns/hickory-dns/commit/4981b8d9151ce7d1ecc7593d37e053b0707a1d0d) cleanup transition to tracing - [`6509957`](https://github.com/hickory-dns/hickory-dns/commit/6509957510ec5930d764ea7c7e840f94ddad4a06) updates from PR review for tracing - [`6772fb0`](https://github.com/hickory-dns/hickory-dns/commit/6772fb0cab0aabe035b237ffc87e5767dc32f8de) update Windows OpenSSL version to 1_1_1o - [`57c5b1f`](https://github.com/hickory-dns/hickory-dns/commit/57c5b1f6afc28860f3e1979381fb4de5e480f16b) rebase to main for tracing ### 📊 Changes **76 files changed** (+357 additions, -253 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+101 -38) 📝 `Makefile.toml` (+1 -1) 📝 `bin/Cargo.toml` (+2 -3) 📝 `bin/src/named.rs` (+77 -55) 📝 `bin/tests/named_https_tests.rs` (+0 -3) 📝 `bin/tests/named_openssl_tests.rs` (+0 -3) 📝 `bin/tests/named_quic_tests.rs` (+0 -3) 📝 `bin/tests/named_rustls_tests.rs` (+0 -3) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+2 -4) 📝 `bin/tests/named_tests.rs` (+0 -3) 📝 `bin/tests/server_harness/mod.rs` (+1 -0) 📝 `crates/client/Cargo.toml` (+2 -1) 📝 `crates/client/src/client/async_client.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/signer.rs` (+3 -1) 📝 `crates/client/src/rr/dnssec/tsig.rs` (+3 -1) 📝 `crates/client/src/serialize/txt/rdata_parsers/caa.rs` (+1 -1) 📝 `crates/proto/Cargo.toml` (+2 -2) 📝 `crates/proto/src/https/https_client_stream.rs` (+1 -1) 📝 `crates/proto/src/https/https_server.rs` (+1 -1) 📝 `crates/proto/src/https/request.rs` (+1 -1) _...and 56 more files_ </details> ### 📄 Description @erikh, I hope you don't mind, I took your changes and made the last few changes necessary. @djc, Do you think this would require a major bump to the version? I think the log-line structure for the `named` binary is consistent with it's original output if not identical (it's pretty close). @hawkw, could I bother you for your opinion on this? closes: #1667 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>