[PR #1704] [MERGED] Support loading pkcs#1 private key as well #2536

New issue

Closed

opened 2026-03-16 10:06:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:06:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1704
Author: @lisongmin
Created: 4/26/2022
Status: ✅ Merged
Merged: 4/28/2022
Merged by: @djc

Base: main ← Head: support-loading-pkcs1-private-key

📝 Commits (1)

a9c3947 Support loading pkcs#1 private key as well

📊 Changes

2 files changed (+12 additions, -24 deletions)

View changed files

📝 crates/proto/src/rustls/tls_server.rs (+10 -22)
📝 crates/server/src/config/dnssec.rs (+2 -2)

📄 Description

I want to use the key pair generated by step-ca, and failed because it is saving as pkcs1 format like that:

-----BEGIN EC PRIVATE KEY-----
...
-----END EC PRIVATE KEY-----

pkcs8 is the future, but now there are many private keys saving as pkcs1 format.
It's better to support them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1704 **Author:** [@lisongmin](https://github.com/lisongmin) **Created:** 4/26/2022 **Status:** ✅ Merged **Merged:** 4/28/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `support-loading-pkcs1-private-key` --- ### 📝 Commits (1) - [`a9c3947`](https://github.com/hickory-dns/hickory-dns/commit/a9c39477ed84f91095d9e602f56895781e63074e) Support loading pkcs#1 private key as well ### 📊 Changes **2 files changed** (+12 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rustls/tls_server.rs` (+10 -22) 📝 `crates/server/src/config/dnssec.rs` (+2 -2) </details> ### 📄 Description I want to use the key pair generated by step-ca, and failed because it is saving as pkcs1 format like that: ``` -----BEGIN EC PRIVATE KEY----- ... -----END EC PRIVATE KEY----- ``` pkcs8 is the future, but now there are many private keys saving as pkcs1 format. It's better to support them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>