[PR #1678] Fix SvcParamKey::Unknown parsing #2507

New issue

Closed

opened 2026-03-16 09:32:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 09:32:44 +03:00

Owner

Original Pull Request: https://github.com/hickory-dns/hickory-dns/pull/1678

State: closed
Merged: Yes

Addresses https://github.com/bluejekyll/trust-dns/issues/1677

Unfortunately it looks like this might break Key(_) parsing if they're collections, but I'm not sure what the spec says about those necessarily being collections versus arbitrary data. If so, a separate fn parse_keys should be added to svcb.rs.

**Original Pull Request:** https://github.com/hickory-dns/hickory-dns/pull/1678 **State:** closed **Merged:** Yes --- Addresses https://github.com/bluejekyll/trust-dns/issues/1677 Unfortunately it looks like this might break Key(_) parsing if they're collections, but I'm not sure what the spec says about those necessarily being collections versus arbitrary data. If so, a separate `fn parse_keys` should be added to `svcb.rs`.