[PR #1678] [MERGED] Fix SvcParamKey::Unknown parsing #2505

New issue

Closed

opened 2026-03-16 09:16:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 09:16:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1678
Author: @jeff-hiner
Created: 4/7/2022
Status: ✅ Merged
Merged: 4/8/2022
Merged by: @bluejekyll

Base: main ← Head: fix_svcparamkey_unknown

📝 Commits (1)

5b845ec Fix SvcParamKey::Unknown parsing

📊 Changes

2 files changed (+11 additions, -19 deletions)

View changed files

📝 crates/client/src/serialize/txt/rdata_parsers/svcb.rs (+2 -5)
📝 crates/proto/src/rr/rdata/svcb.rs (+9 -14)

📄 Description

Addresses https://github.com/bluejekyll/trust-dns/issues/1677

Unfortunately it looks like this might break Key(_) parsing if they're collections, but I'm not sure what the spec says about those necessarily being collections versus arbitrary data. If so, a separate fn parse_keys should be added to svcb.rs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1678 **Author:** [@jeff-hiner](https://github.com/jeff-hiner) **Created:** 4/7/2022 **Status:** ✅ Merged **Merged:** 4/8/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix_svcparamkey_unknown` --- ### 📝 Commits (1) - [`5b845ec`](https://github.com/hickory-dns/hickory-dns/commit/5b845ec08f312a8b139b653266cd08322c83c437) Fix SvcParamKey::Unknown parsing ### 📊 Changes **2 files changed** (+11 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/rdata_parsers/svcb.rs` (+2 -5) 📝 `crates/proto/src/rr/rdata/svcb.rs` (+9 -14) </details> ### 📄 Description Addresses https://github.com/bluejekyll/trust-dns/issues/1677 Unfortunately it looks like this might break Key(_) parsing if they're collections, but I'm not sure what the spec says about those necessarily being collections versus arbitrary data. If so, a separate `fn parse_keys` should be added to `svcb.rs`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>