[GH-ISSUE #36] Remove panic!() from op_code From impl #25

New issue

Closed

opened 2026-03-07 22:18:05 +03:00 by kerem · 3 comments

kerem commented

2026-03-07 22:18:05 +03:00

Owner

Originally created by @bluejekyll on GitHub (Aug 20, 2016).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/36

https://github.com/bluejekyll/trust-dns/blob/master/src/op/op_code.rs#L99

Might need to change away from the From trait and move towards a parser.

Originally created by @bluejekyll on GitHub (Aug 20, 2016). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/36 https://github.com/bluejekyll/trust-dns/blob/master/src/op/op_code.rs#L99 Might need to change away from the From trait and move towards a parser.

kerem

2026-03-07 22:18:05 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-07 22:18:06 +03:00

Author

Owner

@alserio commented on GitHub (Aug 21, 2016):

Hi, just a quick note. The From trait documentation explicitly says:

Note: this trait must not fail. If the conversion can fail, use TryFrom or a dedicated method which returns an Option or a Result<T, E>.

@alserio commented on GitHub (Aug 21, 2016): Hi, just a quick note. The [From trait documentation](https://doc.rust-lang.org/std/convert/trait.From.html) explicitly says: > Note: this trait must not fail. If the conversion can fail, use TryFrom or a dedicated method which returns an Option<T> or a Result<T, E>.

kerem commented

2026-03-07 22:18:07 +03:00

Author

Owner

@bluejekyll commented on GitHub (Aug 22, 2016):

Yes, I'm aware of that restriction. I'll most likely be dropping the usage of that trait in this context in order to fix this bug.

@bluejekyll commented on GitHub (Aug 22, 2016): Yes, I'm aware of that restriction. I'll most likely be dropping the usage of that trait in this context in order to fix this bug.

kerem commented

2026-03-07 22:18:07 +03:00

Author

Owner

@bluejekyll commented on GitHub (Aug 27, 2016):

Fixed in #42

@bluejekyll commented on GitHub (Aug 27, 2016): Fixed in #42

kerem referenced this issue

2026-03-15 21:54:54 +03:00

[GH-ISSUE #25] Verify no resource leak in MIO and event registry #318