[PR #1665] [MERGED] crates/server, InMemoryStore: Use a RwLock instead of a Mutex to manage inner storage #2494

New issue

Closed

opened 2026-03-16 09:05:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 09:05:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1665
Author: @erikh
Created: 3/24/2022
Status: ✅ Merged
Merged: 3/24/2022
Merged by: @bluejekyll

Base: main ← Head: rwlock-inmemorystore

📝 Commits (2)

8a469bb crates/server, InMemoryStore: Use a RwLock instead of a Mutex to manage inner storage
7498308 crates/server InMemoryAuthority: Clone records() instead of returning a ref

📊 Changes

2 files changed (+23 additions, -21 deletions)

View changed files

📝 crates/server/Cargo.toml (+1 -1)
📝 crates/server/src/store/in_memory/authority.rs (+22 -20)

📄 Description

This was causing unexpected deadlocks during usage.

Signed-off-by: Erik Hollensbe git@hollensbe.org

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1665 **Author:** [@erikh](https://github.com/erikh) **Created:** 3/24/2022 **Status:** ✅ Merged **Merged:** 3/24/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `rwlock-inmemorystore` --- ### 📝 Commits (2) - [`8a469bb`](https://github.com/hickory-dns/hickory-dns/commit/8a469bb41cca3d19a79a0463ae393a1a86a599e9) crates/server, InMemoryStore: Use a RwLock instead of a Mutex to manage inner storage - [`7498308`](https://github.com/hickory-dns/hickory-dns/commit/7498308e81cfea4646c6e2ecb8f8d03a484a1683) crates/server InMemoryAuthority: Clone records() instead of returning a ref ### 📊 Changes **2 files changed** (+23 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/Cargo.toml` (+1 -1) 📝 `crates/server/src/store/in_memory/authority.rs` (+22 -20) </details> ### 📄 Description This was causing unexpected deadlocks during usage. Signed-off-by: Erik Hollensbe <git@hollensbe.org> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>