[PR #1667] [CLOSED] Move log to tracing package #2493

New issue

Closed

opened 2026-03-16 09:05:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 09:05:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1667
Author: @erikh
Created: 3/25/2022
Status: ❌ Closed

Base: main ← Head: tracing

📝 Commits (3)

69fe26c Move log to tracing package
10c37f7 Move util subpackage to tracing package
03e763f Restore enabled checks with level_enabled! macro

📊 Changes

72 files changed (+328 additions, -296 deletions)

View changed files

📝 Cargo.lock (+170 -63)
📝 bin/Cargo.toml (+2 -2)
📝 bin/src/named.rs (+37 -14)
📝 bin/tests/named_https_tests.rs (+0 -3)
📝 bin/tests/named_rustls_tests.rs (+0 -3)
📝 bin/tests/named_test_rsa_dnssec.rs (+1 -4)
📝 bin/tests/named_tests.rs (+0 -3)
📝 bin/tests/server_harness/mod.rs (+2 -1)
📝 crates/client/Cargo.toml (+2 -1)
📝 crates/client/src/client/async_client.rs (+1 -1)
📝 crates/client/src/rr/dnssec/signer.rs (+3 -1)
📝 crates/client/src/rr/dnssec/tsig.rs (+3 -1)
📝 crates/client/src/serialize/txt/rdata_parsers/caa.rs (+1 -1)
📝 crates/proto/Cargo.toml (+2 -2)
📝 crates/proto/src/https/https_client_stream.rs (+1 -1)
📝 crates/proto/src/https/https_server.rs (+1 -1)
📝 crates/proto/src/https/request.rs (+1 -1)
📝 crates/proto/src/multicast/mdns_stream.rs (+1 -1)
📝 crates/proto/src/op/message.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+1 -1)

...and 52 more files

📄 Description

This is preliminary and needs some work still, but compiles and tests. I know this is a slog of a review, but please lmk if you'd like anything major changed. I also don't have a great env for testing trust-dns changes properly so any assistance here would be helpful.

Fundamentally, this patch just changes out the logging for the tracing package, except for util which was left mostly alone. In all cases env_logger was replaced with the tracing_subscriber package. crates/server/src/logger.rs was completely gutted and replaced with a a tracing aware solution.

This may not be what you want, but I hope it's in the right direction. Thanks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1667 **Author:** [@erikh](https://github.com/erikh) **Created:** 3/25/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `tracing` --- ### 📝 Commits (3) - [`69fe26c`](https://github.com/hickory-dns/hickory-dns/commit/69fe26c4d47311351d6c8dff693b09e492ac0af4) Move log to tracing package - [`10c37f7`](https://github.com/hickory-dns/hickory-dns/commit/10c37f78cf8ab68fa16fd0cd65f4a2fbb109aef4) Move util subpackage to tracing package - [`03e763f`](https://github.com/hickory-dns/hickory-dns/commit/03e763f28010a0ac3b7f2f745f77c4fa8b403cb8) Restore enabled checks with level_enabled! macro ### 📊 Changes **72 files changed** (+328 additions, -296 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+170 -63) 📝 `bin/Cargo.toml` (+2 -2) 📝 `bin/src/named.rs` (+37 -14) 📝 `bin/tests/named_https_tests.rs` (+0 -3) 📝 `bin/tests/named_rustls_tests.rs` (+0 -3) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+1 -4) 📝 `bin/tests/named_tests.rs` (+0 -3) 📝 `bin/tests/server_harness/mod.rs` (+2 -1) 📝 `crates/client/Cargo.toml` (+2 -1) 📝 `crates/client/src/client/async_client.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/signer.rs` (+3 -1) 📝 `crates/client/src/rr/dnssec/tsig.rs` (+3 -1) 📝 `crates/client/src/serialize/txt/rdata_parsers/caa.rs` (+1 -1) 📝 `crates/proto/Cargo.toml` (+2 -2) 📝 `crates/proto/src/https/https_client_stream.rs` (+1 -1) 📝 `crates/proto/src/https/https_server.rs` (+1 -1) 📝 `crates/proto/src/https/request.rs` (+1 -1) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+1 -1) 📝 `crates/proto/src/op/message.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+1 -1) _...and 52 more files_ </details> ### 📄 Description This is preliminary and needs some work still, but compiles and tests. I know this is a slog of a review, but please lmk if you'd like anything major changed. I also don't have a great env for testing trust-dns changes properly so any assistance here would be helpful. Fundamentally, this patch just changes out the logging for the tracing package, except for `util` which was left mostly alone. In all cases `env_logger` was replaced with the `tracing_subscriber` package. `crates/server/src/logger.rs` was completely gutted and replaced with a a tracing aware solution. This may not be what you want, but I hope it's in the right direction. Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>