[PR #1657] [MERGED] Stop searching for additional records when encountering a name already seen. Fixes #1283 #2489

New issue

Closed

opened 2026-03-16 08:56:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:56:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1657
Author: @Mossop
Created: 3/8/2022
Status: ✅ Merged
Merged: 3/8/2022
Merged by: @bluejekyll

Base: main ← Head: cname-loop

📝 Commits (3)

14b4e59 Stop searching for additional records when encountering a name already seen. Fixes #1283
a4f8132 Track seen names for each query type.
1aba3e7 Fix clippy lint.

📊 Changes

2 files changed (+173 additions, -9 deletions)

View changed files

📝 crates/server/src/store/in_memory/authority.rs (+24 -9)
➕ crates/server/tests/in_memory.rs (+149 -0)

📄 Description

I've assumed that including the original record in additionals is incorrect so I had to pass in the original name to stop that from happening. Also seems that the continue_name variable is unnecessary.

fixes: #1283

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1657 **Author:** [@Mossop](https://github.com/Mossop) **Created:** 3/8/2022 **Status:** ✅ Merged **Merged:** 3/8/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `cname-loop` --- ### 📝 Commits (3) - [`14b4e59`](https://github.com/hickory-dns/hickory-dns/commit/14b4e59e48ef2c56754e41d9306b68d56bb6e9aa) Stop searching for additional records when encountering a name already seen. Fixes #1283 - [`a4f8132`](https://github.com/hickory-dns/hickory-dns/commit/a4f813278d5e283089fc9bd0775b1f1f116df24f) Track seen names for each query type. - [`1aba3e7`](https://github.com/hickory-dns/hickory-dns/commit/1aba3e76f32fd54c450bbbcfa5ce39e8f8d1a8fd) Fix clippy lint. ### 📊 Changes **2 files changed** (+173 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/in_memory/authority.rs` (+24 -9) ➕ `crates/server/tests/in_memory.rs` (+149 -0) </details> ### 📄 Description I've assumed that including the original record in additionals is incorrect so I had to pass in the original name to stop that from happening. Also seems that the `continue_name` variable is unnecessary. fixes: #1283 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>