[PR #1620] [MERGED] pass RequestInfo into Authority on search #2464

New issue

Closed

opened 2026-03-16 08:55:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:55:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1620
Author: @bluejekyll
Created: 1/30/2022
Status: ✅ Merged
Merged: 2/6/2022
Merged by: @bluejekyll

Base: main ← Head: request-info-authority

📝 Commits (1)

9e8ea5c pass RequestInfo into Authority on search

📊 Changes

13 files changed (+457 additions, -116 deletions)

View changed files

📝 crates/proto/src/op/header.rs (+9 -9)
📝 crates/server/src/authority/authority.rs (+3 -5)
📝 crates/server/src/authority/authority_object.rs (+6 -8)
📝 crates/server/src/authority/catalog.rs (+3 -1)
📝 crates/server/src/server/request_handler.rs (+25 -0)
📝 crates/server/src/store/file/authority.rs (+3 -3)
📝 crates/server/src/store/forwarder/authority.rs (+9 -4)
📝 crates/server/src/store/in_memory/authority.rs (+6 -5)
📝 crates/server/src/store/sqlite/authority.rs (+4 -6)
📝 crates/server/tests/authority_battery/basic.rs (+163 -28)
📝 crates/server/tests/authority_battery/dnssec.rs (+37 -7)
📝 crates/server/tests/authority_battery/dynamic_update.rs (+153 -36)
📝 tests/integration-tests/tests/sqlite_authority_tests.rs (+36 -4)

📄 Description

Fixes: #1613

@moschroe, It took me a while to come back around to this.

This is a first pass at adding the request details to the Authority::search method, but should suffice for the original issue. I do want to extend this for DoH, DoT, and eventually DoQ to allow for client cert validation (of some form), though the TLS protocol may actually require a different method that's not authority based. We'll see.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1620 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/30/2022 **Status:** ✅ Merged **Merged:** 2/6/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `request-info-authority` --- ### 📝 Commits (1) - [`9e8ea5c`](https://github.com/hickory-dns/hickory-dns/commit/9e8ea5c037374c3c3231653d0e504ac72e22330f) pass RequestInfo into Authority on search ### 📊 Changes **13 files changed** (+457 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/header.rs` (+9 -9) 📝 `crates/server/src/authority/authority.rs` (+3 -5) 📝 `crates/server/src/authority/authority_object.rs` (+6 -8) 📝 `crates/server/src/authority/catalog.rs` (+3 -1) 📝 `crates/server/src/server/request_handler.rs` (+25 -0) 📝 `crates/server/src/store/file/authority.rs` (+3 -3) 📝 `crates/server/src/store/forwarder/authority.rs` (+9 -4) 📝 `crates/server/src/store/in_memory/authority.rs` (+6 -5) 📝 `crates/server/src/store/sqlite/authority.rs` (+4 -6) 📝 `crates/server/tests/authority_battery/basic.rs` (+163 -28) 📝 `crates/server/tests/authority_battery/dnssec.rs` (+37 -7) 📝 `crates/server/tests/authority_battery/dynamic_update.rs` (+153 -36) 📝 `tests/integration-tests/tests/sqlite_authority_tests.rs` (+36 -4) </details> ### 📄 Description Fixes: #1613 @moschroe, It took me a while to come back around to this. This is a first pass at adding the request details to the `Authority::search` method, but should suffice for the original issue. I do want to extend this for DoH, DoT, and eventually DoQ to allow for client cert validation (of some form), though the TLS protocol may actually require a different method that's not authority based. We'll see. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>