[PR #1598] [MERGED] Fix AsyncClient::clone always setting use_edns #2447

New issue

Closed

opened 2026-03-16 08:54:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:54:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1598
Author: @ecton
Created: 12/5/2021
Status: ✅ Merged
Merged: 12/11/2021
Merged by: @bluejekyll

Base: main ← Head: asyncclient-clone-fix

📝 Commits (1)

501f5f4 AsyncClient::clone now copies use_edns

📊 Changes

1 file changed (+1 additions, -9 deletions)

View changed files

📝 crates/client/src/client/async_client.rs (+1 -9)

📄 Description

In looking at diffs while investigating the root cause of #1597, I saw this clone implementation, and it looked suspicious. From my reading of the surrounding code and the changelog entry, it seems like the flag should be preserved, not overwritten.

Apologies if I misunderstood and this was intended!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1598 **Author:** [@ecton](https://github.com/ecton) **Created:** 12/5/2021 **Status:** ✅ Merged **Merged:** 12/11/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `asyncclient-clone-fix` --- ### 📝 Commits (1) - [`501f5f4`](https://github.com/hickory-dns/hickory-dns/commit/501f5f441866516533de76ce1386e6057c4d161a) AsyncClient::clone now copies use_edns ### 📊 Changes **1 file changed** (+1 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/client/async_client.rs` (+1 -9) </details> ### 📄 Description In looking at diffs while investigating the root cause of #1597, I saw this clone implementation, and it looked suspicious. From my reading of the surrounding code and the changelog entry, it seems like the flag should be preserved, not overwritten. Apologies if I misunderstood and this was intended! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>