[PR #1592] [MERGED] Use stream connections if datagram connections are not available #2441

Closed
opened 2026-03-16 08:54:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1592
Author: @pinkisemils
Created: 11/18/2021
Status: Merged
Merged: 11/19/2021
Merged by: @bluejekyll

Base: mainHead: use-stream-resolvers


📝 Commits (1)

  • 3fb855d e stream resolvers if UDP ones are not available

📊 Changes

2 files changed (+20 additions, -5 deletions)

View changed files

📝 crates/resolver/src/error.rs (+17 -0)
📝 crates/resolver/src/name_server/name_server_pool.rs (+3 -5)

📄 Description

If a forwarder is configured to use solely TCP based resolvers, they will never be used, and no resolution will ever take place. This behavior was introduced #1562,

Fixes: #1590


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1592 **Author:** [@pinkisemils](https://github.com/pinkisemils) **Created:** 11/18/2021 **Status:** ✅ Merged **Merged:** 11/19/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `use-stream-resolvers` --- ### 📝 Commits (1) - [`3fb855d`](https://github.com/hickory-dns/hickory-dns/commit/3fb855d70d7cfe6e05f87b9bd200b15ff93bb322) e stream resolvers if UDP ones are not available ### 📊 Changes **2 files changed** (+20 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/error.rs` (+17 -0) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+3 -5) </details> ### 📄 Description If a forwarder is configured to use solely TCP based resolvers, they will never be used, and no resolution will ever take place. This behavior was introduced #1562, Fixes: #1590 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 08:54:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2441
No description provided.