[PR #1578] [MERGED] Remove unused field on NameServerPool #2435

New issue

Closed

opened 2026-03-16 08:53:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:53:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1578
Author: @pinkisemils
Created: 10/27/2021
Status: ✅ Merged
Merged: 11/4/2021
Merged by: @bluejekyll

Base: main ← Head: trim-nameserverpool-field

📝 Commits (3)

564b3c8 Allow constructing responses for lib users
c142226 Replace 'backtrace' with 'with-backtrace'
dd2ce6d Remove unused field on NameServerPool

📊 Changes

6 files changed (+29 additions, -40 deletions)

View changed files

📝 crates/resolver/src/error.rs (+4 -4)
📝 crates/resolver/src/name_server/name_server_pool.rs (+2 -12)
📝 crates/server/src/authority/message_response.rs (+14 -2)
📝 crates/server/src/error/config_error.rs (+1 -1)
📝 crates/server/src/error/persistence_error.rs (+1 -1)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+7 -20)

📄 Description

The NameServerPool doesn't ever need to use a connection provider, it is however used by it's members (datagram_conns and stream_conns). As such, I've removed the field itself and fixed the tests where there was an extra parameter passed around to populate the field on NameServerPool.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1578 **Author:** [@pinkisemils](https://github.com/pinkisemils) **Created:** 10/27/2021 **Status:** ✅ Merged **Merged:** 11/4/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `trim-nameserverpool-field` --- ### 📝 Commits (3) - [`564b3c8`](https://github.com/hickory-dns/hickory-dns/commit/564b3c89e12346ba41d11ece6d7b9506cf8f7ca1) Allow constructing responses for lib users - [`c142226`](https://github.com/hickory-dns/hickory-dns/commit/c142226a9b790e73b59f752df02135f00d84daa3) Replace 'backtrace' with 'with-backtrace' - [`dd2ce6d`](https://github.com/hickory-dns/hickory-dns/commit/dd2ce6de7a3b648989c43a3bd4ca1bfdb70f3815) Remove unused field on NameServerPool ### 📊 Changes **6 files changed** (+29 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/error.rs` (+4 -4) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+2 -12) 📝 `crates/server/src/authority/message_response.rs` (+14 -2) 📝 `crates/server/src/error/config_error.rs` (+1 -1) 📝 `crates/server/src/error/persistence_error.rs` (+1 -1) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+7 -20) </details> ### 📄 Description The `NameServerPool` doesn't ever need to use a connection provider, it is however used by it's members (`datagram_conns` and `stream_conns`). As such, I've removed the field itself and fixed the tests where there was an extra parameter passed around to populate the field on `NameServerPool`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>