[PR #1551] [MERGED] remove unused doc arg line & bytesmut #2412

New issue

Closed

opened 2026-03-16 08:52:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:52:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1551
Author: @leshow
Created: 9/6/2021
Status: ✅ Merged
Merged: 9/14/2021
Merged by: @bluejekyll

Base: main ← Head: minor_doh

📝 Commits (2)

5417dca remove unused arg line & bytesmut
8e91b6c Merge branch 'main' into minor_doh

📊 Changes

1 file changed (+5 additions, -11 deletions)

View changed files

📝 crates/proto/src/https/https_client_stream.rs (+5 -11)

📄 Description

Found a line in the docs I don't think is in use anymore. Also noticed BytesMut::from(&[u8]) that can be removed, which I think causes one extra allocation per send_message, this required changing the method signature on an internal method though, so let me know if you'd prefer this was rolled back.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1551 **Author:** [@leshow](https://github.com/leshow) **Created:** 9/6/2021 **Status:** ✅ Merged **Merged:** 9/14/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `minor_doh` --- ### 📝 Commits (2) - [`5417dca`](https://github.com/hickory-dns/hickory-dns/commit/5417dcabd22e1d297472e0d8c18112ddcac33bf7) remove unused arg line & bytesmut - [`8e91b6c`](https://github.com/hickory-dns/hickory-dns/commit/8e91b6cc746a636b1bccb97b2c51323f66e6feb7) Merge branch 'main' into minor_doh ### 📊 Changes **1 file changed** (+5 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/https/https_client_stream.rs` (+5 -11) </details> ### 📄 Description Found a line in the docs I don't think is in use anymore. Also noticed `BytesMut::from(&[u8])` that can be removed, which I think causes one extra allocation per `send_message`, this required changing the method signature on an internal method though, so let me know if you'd prefer this was rolled back. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>