[PR #1536] [MERGED] Make `trust_dns_proto::rr::Record` serializable #2399

New issue

Closed

opened 2026-03-16 08:51:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:51:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1536
Author: @mvforell
Created: 8/11/2021
Status: ✅ Merged
Merged: 8/26/2021
Merged by: @bluejekyll

Base: main ← Head: main

📝 Commits (5)

e251db2 make trust_dns_proto::rr::Record serializable
2e19fee enable url/serde only for the serde-config feature
4116f50 Merge branch 'main' into main
ba4174e fix deprecation warnings for proto::rr::dnssec::rdata::key
6024eaf Merge branch 'main' into main

📊 Changes

31 files changed (+142 additions, -17 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 crates/proto/Cargo.toml (+1 -1)
📝 crates/proto/src/rr/dns_class.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/algorithm.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/digest_type.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/nsec3.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/key.rs (+9 -16)
📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+5 -0)
📝 crates/proto/src/rr/dnssec/rdata/nsec.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/nsec3.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/nsec3param.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/sig.rs (+4 -0)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+5 -0)
📝 crates/proto/src/rr/dnssec/supported_algorithm.rs (+4 -0)
📝 crates/proto/src/rr/rdata/caa.rs (+7 -0)
📝 crates/proto/src/rr/rdata/hinfo.rs (+4 -0)
📝 crates/proto/src/rr/rdata/mx.rs (+4 -0)
📝 crates/proto/src/rr/rdata/naptr.rs (+4 -0)

...and 11 more files

📄 Description

When using the serde-config feature, I noticed that the trust_dns_proto::rr::Record is not Deserialize and Serialize. This can be achieved by adding a conditional derive to all its subtypes.

There are some deprecation warnings for crates/proto/src/rr/dnssec/rdata/key.rs, but I'm not sure how to fix them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1536 **Author:** [@mvforell](https://github.com/mvforell) **Created:** 8/11/2021 **Status:** ✅ Merged **Merged:** 8/26/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`e251db2`](https://github.com/hickory-dns/hickory-dns/commit/e251db2c9d4cc039d0d4f26d940458ae9627856a) make trust_dns_proto::rr::Record serializable - [`2e19fee`](https://github.com/hickory-dns/hickory-dns/commit/2e19fee9f6d3e8054aecb39cbf769c57644550a3) enable url/serde only for the serde-config feature - [`4116f50`](https://github.com/hickory-dns/hickory-dns/commit/4116f505ea23bd949092c11ee13fb11ff7f7aa85) Merge branch 'main' into main - [`ba4174e`](https://github.com/hickory-dns/hickory-dns/commit/ba4174edbf64f0996b61a5c6b43182172fa687c6) fix deprecation warnings for proto::rr::dnssec::rdata::key - [`6024eaf`](https://github.com/hickory-dns/hickory-dns/commit/6024eaf57373a4f1b0214b1c354f3921d0fdc79b) Merge branch 'main' into main ### 📊 Changes **31 files changed** (+142 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `crates/proto/Cargo.toml` (+1 -1) 📝 `crates/proto/src/rr/dns_class.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/algorithm.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/digest_type.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/key.rs` (+9 -16) 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+5 -0) 📝 `crates/proto/src/rr/dnssec/rdata/nsec.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3param.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/sig.rs` (+4 -0) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+5 -0) 📝 `crates/proto/src/rr/dnssec/supported_algorithm.rs` (+4 -0) 📝 `crates/proto/src/rr/rdata/caa.rs` (+7 -0) 📝 `crates/proto/src/rr/rdata/hinfo.rs` (+4 -0) 📝 `crates/proto/src/rr/rdata/mx.rs` (+4 -0) 📝 `crates/proto/src/rr/rdata/naptr.rs` (+4 -0) _...and 11 more files_ </details> ### 📄 Description When using the `serde-config` feature, I noticed that the `trust_dns_proto::rr::Record` is not `Deserialize` and `Serialize`. This can be achieved by adding a conditional derive to all its subtypes. There are some deprecation warnings for `crates/proto/src/rr/dnssec/rdata/key.rs`, but I'm not sure how to fix them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>