[PR #1539] [MERGED] Improved doc example for async client usage #2398

New issue

Closed

opened 2026-03-16 08:51:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:51:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1539
Author: @ErwanDL
Created: 8/18/2021
Status: ✅ Merged
Merged: 8/20/2021
Merged by: @bluejekyll

Base: main ← Head: improve-async-client-documentation

📝 Commits (3)

6a4e450 improve doc example for async client usage
2da7ee3 improve comment
8fc6a5e Merge branch 'main' into improve-async-client-documentation

📊 Changes

1 file changed (+43 additions, -40 deletions)

View changed files

📝 crates/client/src/lib.rs (+43 -40)

📄 Description

This is the first PR associated with #1532 (sorry for the delay). It replaces the existing async client example with what I hope is an improved example, making use of the async/await syntax and using the #[tokio::main] macro, which should make it even easier to understand for newcomers. I also choose to setup a TCP connection in this example instead of UDP, so that both options are covered by different examples.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1539 **Author:** [@ErwanDL](https://github.com/ErwanDL) **Created:** 8/18/2021 **Status:** ✅ Merged **Merged:** 8/20/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `improve-async-client-documentation` --- ### 📝 Commits (3) - [`6a4e450`](https://github.com/hickory-dns/hickory-dns/commit/6a4e4504764e94c60107e3e670c3f2e908c82497) improve doc example for async client usage - [`2da7ee3`](https://github.com/hickory-dns/hickory-dns/commit/2da7ee3e49733ebf9c88523f004f92c17f2cea5b) improve comment - [`8fc6a5e`](https://github.com/hickory-dns/hickory-dns/commit/8fc6a5e6f14f4b1b5b480c60e23a7804e7e87c20) Merge branch 'main' into improve-async-client-documentation ### 📊 Changes **1 file changed** (+43 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/lib.rs` (+43 -40) </details> ### 📄 Description This is the first PR associated with #1532 (sorry for the delay). It replaces the existing async client example with what I hope is an improved example, making use of the async/await syntax and using the `#[tokio::main]` macro, which should make it even easier to understand for newcomers. I also choose to setup a TCP connection in this example instead of UDP, so that both options are covered by different examples. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>