[PR #1503] [MERGED] use ring and openssl instead of new deps on hmac and sha2 #2375

Closed
opened 2026-03-16 08:50:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1503
Author: @bluejekyll
Created: 6/3/2021
Status: Merged
Merged: 6/6/2021
Merged by: @bluejekyll

Base: mainHead: prefer-ring-hmac


📝 Commits (2)

  • 10410a6 use ring and openssl instead of new deps on hmac and sha2
  • 8ee97b7 disable HMAC truncation support

📊 Changes

5 files changed (+176 additions, -129 deletions)

View changed files

📝 Cargo.lock (+0 -90)
📝 crates/client/src/rr/dnssec/tsig.rs (+32 -12)
📝 crates/proto/Cargo.toml (+1 -3)
📝 crates/proto/src/error.rs (+5 -0)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+138 -24)

📄 Description

@trinity-1686a and @djc

Thoughts?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1503 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 6/3/2021 **Status:** ✅ Merged **Merged:** 6/6/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `prefer-ring-hmac` --- ### 📝 Commits (2) - [`10410a6`](https://github.com/hickory-dns/hickory-dns/commit/10410a68b971655cc45b42af3f95e644c1f34fe4) use ring and openssl instead of new deps on hmac and sha2 - [`8ee97b7`](https://github.com/hickory-dns/hickory-dns/commit/8ee97b76efddf1094322bcebfc1e1c1c6bcc04f8) disable HMAC truncation support ### 📊 Changes **5 files changed** (+176 additions, -129 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -90) 📝 `crates/client/src/rr/dnssec/tsig.rs` (+32 -12) 📝 `crates/proto/Cargo.toml` (+1 -3) 📝 `crates/proto/src/error.rs` (+5 -0) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+138 -24) </details> ### 📄 Description @trinity-1686a and @djc Thoughts? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 08:50:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2375
No description provided.