[PR #1498] [MERGED] Move tsig to dnssec and rename Signer to SigSigner #2367

New issue

Closed

opened 2026-03-16 08:50:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:50:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1498
Author: @bluejekyll
Created: 5/27/2021
Status: ✅ Merged
Merged: 5/30/2021
Merged by: @bluejekyll

Base: main ← Head: move-tsig-to-dnssec

📝 Commits (5)

8082425 move TSIG into DNSSEC to allow for slimmer dependencies
5a1d983 rename Signer to SigSigner to differentiate from TSigner
786b425 Fixup documentation for Signer
9b20b4f remove all deprecated usages of Signer for SigSigner
e59dec8 fix dnssec warnings

📊 Changes

31 files changed (+306 additions, -257 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 crates/async-std-resolver/src/lib.rs (+1 -1)
📝 crates/client/Cargo.toml (+3 -1)
📝 crates/client/src/client/client.rs (+10 -7)
📝 crates/client/src/client/client_connection.rs (+24 -5)
📝 crates/client/src/lib.rs (+2 -2)
📝 crates/client/src/rr/dnssec/mod.rs (+5 -1)
📝 crates/client/src/rr/dnssec/signer.rs (+37 -45)
📝 crates/client/src/rr/dnssec/tsig.rs (+6 -5)
📝 crates/client/src/rr/mod.rs (+0 -1)
📝 crates/proto/Cargo.toml (+3 -3)
📝 crates/proto/src/op/message.rs (+7 -3)
📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+142 -0)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+9 -4)
📝 crates/proto/src/rr/rdata/mod.rs (+0 -2)
📝 crates/proto/src/rr/record_data.rs (+1 -123)
📝 crates/proto/src/rr/record_type.rs (+5 -11)
📝 crates/resolver/src/name_server/name_server.rs (+1 -0)
📝 crates/resolver/src/name_server/name_server_pool.rs (+1 -0)
📝 crates/server/src/authority/authority.rs (+2 -2)

...and 11 more files

📄 Description

Some cleanup after the TSIG support was added.

@trinity-1686a I missed this in the previous review. To keep the resolver dependencies at a minimum, we've been trying to keep signing logic, etc, isolated to the dnssec feature. I moved tsig in the first commit. In the second commit, I renamed Signer to SigSigner, to have a better name separate from the TSigner. SigSigner is used for more than SIG0, it's also used for RRSIG in DNSSEC.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1498 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 5/27/2021 **Status:** ✅ Merged **Merged:** 5/30/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `move-tsig-to-dnssec` --- ### 📝 Commits (5) - [`8082425`](https://github.com/hickory-dns/hickory-dns/commit/808242579b53b3f4fc335ddbcfced622c790a337) move TSIG into DNSSEC to allow for slimmer dependencies - [`5a1d983`](https://github.com/hickory-dns/hickory-dns/commit/5a1d9835b87d8d1e4f98ef6191827bc61bfcf296) rename Signer to SigSigner to differentiate from TSigner - [`786b425`](https://github.com/hickory-dns/hickory-dns/commit/786b42547ea14d2236604fb7c7ccc317c44a6c94) Fixup documentation for Signer - [`9b20b4f`](https://github.com/hickory-dns/hickory-dns/commit/9b20b4f4ca57f10bd0e95d9e4a6712de356f2235) remove all deprecated usages of Signer for SigSigner - [`e59dec8`](https://github.com/hickory-dns/hickory-dns/commit/e59dec8c4c283efe73e392b59e8eec1b9625c302) fix dnssec warnings ### 📊 Changes **31 files changed** (+306 additions, -257 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `crates/async-std-resolver/src/lib.rs` (+1 -1) 📝 `crates/client/Cargo.toml` (+3 -1) 📝 `crates/client/src/client/client.rs` (+10 -7) 📝 `crates/client/src/client/client_connection.rs` (+24 -5) 📝 `crates/client/src/lib.rs` (+2 -2) 📝 `crates/client/src/rr/dnssec/mod.rs` (+5 -1) 📝 `crates/client/src/rr/dnssec/signer.rs` (+37 -45) 📝 `crates/client/src/rr/dnssec/tsig.rs` (+6 -5) 📝 `crates/client/src/rr/mod.rs` (+0 -1) 📝 `crates/proto/Cargo.toml` (+3 -3) 📝 `crates/proto/src/op/message.rs` (+7 -3) 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+142 -0) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+9 -4) 📝 `crates/proto/src/rr/rdata/mod.rs` (+0 -2) 📝 `crates/proto/src/rr/record_data.rs` (+1 -123) 📝 `crates/proto/src/rr/record_type.rs` (+5 -11) 📝 `crates/resolver/src/name_server/name_server.rs` (+1 -0) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+1 -0) 📝 `crates/server/src/authority/authority.rs` (+2 -2) _...and 11 more files_ </details> ### 📄 Description Some cleanup after the TSIG support was added. @trinity-1686a I missed this in the previous review. To keep the resolver dependencies at a minimum, we've been trying to keep signing logic, etc, isolated to the `dnssec` feature. I moved tsig in the first commit. In the second commit, I renamed `Signer` to `SigSigner`, to have a better name separate from the `TSigner`. `SigSigner` is used for more than `SIG0`, it's also used for `RRSIG` in DNSSEC. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>