[PR #1479] [MERGED] add onion special domain handling #2358

New issue

Closed

opened 2026-03-16 08:49:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:49:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1479
Author: @trinity-1686a
Created: 5/5/2021
Status: ✅ Merged
Merged: 5/8/2021
Merged by: @bluejekyll

Base: main ← Head: onion

📝 Commits (3)

ffd48b6 add onion special name handling
110a79e try to prevent search of onion domain as subdomain of a search zone
242c17f clippy

📊 Changes

4 files changed (+88 additions, -2 deletions)

View changed files

📝 crates/client/src/rr/zone.rs (+16 -0)
📝 crates/proto/src/rr/domain/usage.rs (+24 -0)
📝 crates/resolver/src/async_resolver.rs (+46 -1)
📝 crates/resolver/src/caching_client.rs (+2 -1)

📄 Description

fix #1382
For search, as it's possible to have a domain like something.onion.example.com, but very unlikely to have <valid_key>.onion.example.com, this try to evaluate whether the something.onion might be a valid Tor onion domain name based on the length of the name. This match only V3 onion domains (56 chars long), as V2 (16 chars long) are deprecated and will soon be no longer supported

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1479 **Author:** [@trinity-1686a](https://github.com/trinity-1686a) **Created:** 5/5/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `onion` --- ### 📝 Commits (3) - [`ffd48b6`](https://github.com/hickory-dns/hickory-dns/commit/ffd48b6770a0d64693c9a560d553cb0c4df38b9e) add onion special name handling - [`110a79e`](https://github.com/hickory-dns/hickory-dns/commit/110a79e6617f543df5cb9c3b86600825cbf10d8d) try to prevent search of onion domain as subdomain of a search zone - [`242c17f`](https://github.com/hickory-dns/hickory-dns/commit/242c17f189ca4838e027fba3b12c72cafb6070f3) clippy ### 📊 Changes **4 files changed** (+88 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/rr/zone.rs` (+16 -0) 📝 `crates/proto/src/rr/domain/usage.rs` (+24 -0) 📝 `crates/resolver/src/async_resolver.rs` (+46 -1) 📝 `crates/resolver/src/caching_client.rs` (+2 -1) </details> ### 📄 Description fix #1382 For search, as it's possible to have a domain like `something.onion.example.com`, but very unlikely to have `<valid_key>.onion.example.com`, this try to evaluate whether the `something.onion` might be a valid Tor onion domain name based on the length of the name. This match only V3 onion domains (56 chars long), as V2 (16 chars long) [are deprecated](https://blog.torproject.org/v2-deprecation-timeline) and will soon be no longer supported --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>