[PR #1466] [CLOSED] allow receiving multiple response to a single zone transfert request #2343

New issue

Closed

opened 2026-03-16 08:48:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:48:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1466
Author: @trinity-1686a
Created: 4/20/2021
Status: ❌ Closed

Base: main ← Head: xfr-multiple-response

📝 Commits (2)

c882f9e allow receiving multiple response to a single zone transfert request
2a7cc37 add test for receiving multi-message xfr response

📊 Changes

4 files changed (+429 additions, -20 deletions)

View changed files

📝 crates/proto/Cargo.toml (+1 -1)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+330 -10)
📝 crates/proto/src/xfer/dns_response.rs (+97 -8)
📝 tests/integration-tests/src/lib.rs (+1 -1)

📄 Description

fix #1277
This does not allow to transmit a zone of unlimited size, but only up to 1000 messages (arbitrary number), which seems enough for most use-cases. There is no easy way to apply back-pressure on the stream sending the zone, so even if the code used Streams more, there would still be the need for a limit.
This would probably need some test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1466 **Author:** [@trinity-1686a](https://github.com/trinity-1686a) **Created:** 4/20/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `xfr-multiple-response` --- ### 📝 Commits (2) - [`c882f9e`](https://github.com/hickory-dns/hickory-dns/commit/c882f9e880740c0f28ea26e8433ca95a499146ea) allow receiving multiple response to a single zone transfert request - [`2a7cc37`](https://github.com/hickory-dns/hickory-dns/commit/2a7cc37e6ac67394b8060db71e69a7efea8f12a6) add test for receiving multi-message xfr response ### 📊 Changes **4 files changed** (+429 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/Cargo.toml` (+1 -1) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+330 -10) 📝 `crates/proto/src/xfer/dns_response.rs` (+97 -8) 📝 `tests/integration-tests/src/lib.rs` (+1 -1) </details> ### 📄 Description fix #1277 This does not allow to transmit a zone of unlimited size, but only up to 1000 messages (arbitrary number), which seems enough for most use-cases. There is no easy way to apply back-pressure on the stream sending the zone, so even if the code used `Stream`s more, there would still be the need for a limit. This would probably need some test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>