[PR #1433] [MERGED] Remove BufStreamHandle #2322

New issue

Closed

opened 2026-03-16 08:47:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:47:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1433
Author: @bluejekyll
Created: 4/1/2021
Status: ✅ Merged
Merged: 4/10/2021
Merged by: @bluejekyll

Base: main ← Head: remove_buf_stream_handle

📝 Commits (6)

bfafdb0 disable mDNS, remove multi-return array
a1dd1fd remove unnecessary BufStreamHandle
405487e rename name_server in UdpSocket and BufDnsStreamHandle to remote_addr
d8788cc Remove unused StreamHandle
c16514e updated CHANGELOG
0757887 fix typo and use type inference

📊 Changes

40 files changed (+184 additions, -300 deletions)

View changed files

📝 CHANGELOG.md (+10 -0)
📝 Makefile.toml (+11 -2)
📝 bin/tests/named_rustls_tests.rs (+2 -2)
📝 crates/client/src/client/async_client.rs (+5 -5)
📝 crates/native-tls/src/tests.rs (+1 -1)
📝 crates/native-tls/src/tls_client_stream.rs (+0 -2)
📝 crates/native-tls/src/tls_stream.rs (+5 -5)
📝 crates/openssl/src/tls_client_stream.rs (+0 -2)
📝 crates/openssl/src/tls_stream.rs (+5 -5)
📝 crates/openssl/tests/openssl_tests.rs (+1 -1)
📝 crates/proto/src/lib.rs (+2 -2)
📝 crates/proto/src/multicast/mdns_client_stream.rs (+4 -6)
📝 crates/proto/src/multicast/mdns_stream.rs (+6 -5)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+3 -13)
📝 crates/proto/src/tcp/tcp_stream.rs (+8 -6)
📝 crates/proto/src/tests/tcp.rs (+1 -0)
📝 crates/proto/src/tests/udp.rs (+2 -1)
📝 crates/proto/src/udp/udp_stream.rs (+9 -8)
📝 crates/proto/src/xfer/dns_handle.rs (+0 -20)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+19 -74)

...and 20 more files

📄 Description

@djc, I'm just doing a little cleanup. I think there are a few todos in here, will move from draft once I change those.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1433 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/1/2021 **Status:** ✅ Merged **Merged:** 4/10/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `remove_buf_stream_handle` --- ### 📝 Commits (6) - [`bfafdb0`](https://github.com/hickory-dns/hickory-dns/commit/bfafdb0a1185c95107db9e23c6b194a2c4e381bd) disable mDNS, remove multi-return array - [`a1dd1fd`](https://github.com/hickory-dns/hickory-dns/commit/a1dd1fd5265165c1e3b2afa07fea35a9d28696a8) remove unnecessary BufStreamHandle - [`405487e`](https://github.com/hickory-dns/hickory-dns/commit/405487e817a957684373c40efc99bb63caeaf6ea) rename name_server in UdpSocket and BufDnsStreamHandle to remote_addr - [`d8788cc`](https://github.com/hickory-dns/hickory-dns/commit/d8788ccf41b516f146b7c3acaeb5b9792d26fead) Remove unused StreamHandle - [`c16514e`](https://github.com/hickory-dns/hickory-dns/commit/c16514e846d5e83bd6b7278955a3fc10984ded23) updated CHANGELOG - [`0757887`](https://github.com/hickory-dns/hickory-dns/commit/07578877b975d8fe2930fb5316d1f53e863451a3) fix typo and use type inference ### 📊 Changes **40 files changed** (+184 additions, -300 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+10 -0) 📝 `Makefile.toml` (+11 -2) 📝 `bin/tests/named_rustls_tests.rs` (+2 -2) 📝 `crates/client/src/client/async_client.rs` (+5 -5) 📝 `crates/native-tls/src/tests.rs` (+1 -1) 📝 `crates/native-tls/src/tls_client_stream.rs` (+0 -2) 📝 `crates/native-tls/src/tls_stream.rs` (+5 -5) 📝 `crates/openssl/src/tls_client_stream.rs` (+0 -2) 📝 `crates/openssl/src/tls_stream.rs` (+5 -5) 📝 `crates/openssl/tests/openssl_tests.rs` (+1 -1) 📝 `crates/proto/src/lib.rs` (+2 -2) 📝 `crates/proto/src/multicast/mdns_client_stream.rs` (+4 -6) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+6 -5) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+3 -13) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+8 -6) 📝 `crates/proto/src/tests/tcp.rs` (+1 -0) 📝 `crates/proto/src/tests/udp.rs` (+2 -1) 📝 `crates/proto/src/udp/udp_stream.rs` (+9 -8) 📝 `crates/proto/src/xfer/dns_handle.rs` (+0 -20) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+19 -74) _...and 20 more files_ </details> ### 📄 Description @djc, I'm just doing a little cleanup. I think there are a few todos in here, will move from draft once I change those. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>