[PR #1434] [MERGED] add IntoName impl for &String #2321

New issue

Closed

opened 2026-03-16 08:47:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:47:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1434
Author: @du-toit
Created: 4/2/2021
Status: ✅ Merged
Merged: 4/2/2021
Merged by: @djc

Base: main ← Head: intoname_impl

📝 Commits (1)

5fbd600 add IntoName impl for &String

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 crates/proto/src/rr/domain/name.rs (+7 -0)

📄 Description

Hi Everyone!

This is for adding the enhancement for issue #1411.
This is my first time contributing to open source so I picked a small issue. I hoped I followed best practices .

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1434 **Author:** [@du-toit](https://github.com/du-toit) **Created:** 4/2/2021 **Status:** ✅ Merged **Merged:** 4/2/2021 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `intoname_impl` --- ### 📝 Commits (1) - [`5fbd600`](https://github.com/hickory-dns/hickory-dns/commit/5fbd6008ab9aff626bd69b16416018f1d7f27d9c) add IntoName impl for &String ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/domain/name.rs` (+7 -0) </details> ### 📄 Description Hi Everyone! This is for adding the enhancement for issue #1411. This is my first time contributing to open source so I picked a small issue. I hoped I followed best practices . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>