[PR #1401] [MERGED] Make all warnings across crates and binaries consistent #2295

New issue

Closed

opened 2026-03-16 08:45:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:45:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1401
Author: @bluejekyll
Created: 3/5/2021
Status: ✅ Merged
Merged: 3/8/2021
Merged by: @bluejekyll

Base: main ← Head: consistent-warnings-across-crates

📝 Commits (1)

603a3ad Make all warnings across crates and binaries consistent

📊 Changes

107 files changed (+383 additions, -223 deletions)

View changed files

📝 bin/src/named.rs (+19 -8)
📝 crates/async-std-resolver/src/lib.rs (+12 -0)
📝 crates/async-std-resolver/src/net.rs (+2 -2)
📝 crates/async-std-resolver/src/runtime.rs (+5 -2)
📝 crates/async-std-resolver/src/time.rs (+1 -0)
📝 crates/client/src/client/async_client.rs (+3 -3)
📝 crates/client/src/client/async_secure_client.rs (+1 -1)
📝 crates/client/src/client/client.rs (+1 -1)
📝 crates/client/src/client/rc_future.rs (+3 -3)
📝 crates/client/src/error/client_error.rs (+1 -1)
📝 crates/client/src/error/dnssec_error.rs (+10 -7)
📝 crates/client/src/error/lexer_error.rs (+1 -1)
📝 crates/client/src/error/parse_error.rs (+1 -1)
📝 crates/client/src/lib.rs (+13 -6)
📝 crates/client/src/multicast/mdns_client_connection.rs (+1 -1)
📝 crates/client/src/op/lower_query.rs (+2 -2)
📝 crates/client/src/rr/dnssec/key_format.rs (+1 -1)
📝 crates/client/src/rr/dnssec/mod.rs (+2 -0)
📝 crates/client/src/rr/dnssec/signer.rs (+2 -2)
📝 crates/client/src/rr/lower_name.rs (+7 -3)

...and 80 more files

📄 Description

@leshow, Here's that PR. This makes all warnings across the crates consistent. I adopted most of your recommendations, except for the Debug one. That would have been really messy because there are a lot of external types that are not themselves Debug.

We can merge this after your PR, since it has the overlap on Copy in the proto crate

depends on: #1397

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1401 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 3/5/2021 **Status:** ✅ Merged **Merged:** 3/8/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `consistent-warnings-across-crates` --- ### 📝 Commits (1) - [`603a3ad`](https://github.com/hickory-dns/hickory-dns/commit/603a3ad977bf29ea7f8b4a949df53a6712c0fc86) Make all warnings across crates and binaries consistent ### 📊 Changes **107 files changed** (+383 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/named.rs` (+19 -8) 📝 `crates/async-std-resolver/src/lib.rs` (+12 -0) 📝 `crates/async-std-resolver/src/net.rs` (+2 -2) 📝 `crates/async-std-resolver/src/runtime.rs` (+5 -2) 📝 `crates/async-std-resolver/src/time.rs` (+1 -0) 📝 `crates/client/src/client/async_client.rs` (+3 -3) 📝 `crates/client/src/client/async_secure_client.rs` (+1 -1) 📝 `crates/client/src/client/client.rs` (+1 -1) 📝 `crates/client/src/client/rc_future.rs` (+3 -3) 📝 `crates/client/src/error/client_error.rs` (+1 -1) 📝 `crates/client/src/error/dnssec_error.rs` (+10 -7) 📝 `crates/client/src/error/lexer_error.rs` (+1 -1) 📝 `crates/client/src/error/parse_error.rs` (+1 -1) 📝 `crates/client/src/lib.rs` (+13 -6) 📝 `crates/client/src/multicast/mdns_client_connection.rs` (+1 -1) 📝 `crates/client/src/op/lower_query.rs` (+2 -2) 📝 `crates/client/src/rr/dnssec/key_format.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/mod.rs` (+2 -0) 📝 `crates/client/src/rr/dnssec/signer.rs` (+2 -2) 📝 `crates/client/src/rr/lower_name.rs` (+7 -3) _...and 80 more files_ </details> ### 📄 Description @leshow, Here's that PR. This makes all warnings across the crates consistent. I adopted most of your recommendations, except for the `Debug` one. That would have been really messy because there are a lot of external types that are not themselves Debug. We can merge this after your PR, since it has the overlap on `Copy` in the `proto` crate depends on: #1397 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>