[PR #1387] [MERGED] backport optional backtrace dependency change to 0.19 #2282

New issue

Closed

opened 2026-03-16 08:45:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:45:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1387
Author: @jmagnuson
Created: 2/24/2021
Status: ✅ Merged
Merged: 3/9/2021
Merged by: @bluejekyll

Base: release/0.19 ← Head: release/0.19-optional-backtrace

📝 Commits (4)

3c0f690 make backtrace dependency optional
171d24a fix backtrace feature naming
cca8363 enable backtrace feature by default for all crates
85e812e Merge branch 'release/0.19' into release/0.19-optional-backtrace

📊 Changes

20 files changed (+156 additions, -60 deletions)

View changed files

📝 Cargo.lock (+4 -4)
📝 crates/async-std-resolver/Cargo.toml (+2 -1)
📝 crates/client/Cargo.toml (+3 -1)
📝 crates/client/src/error/client_error.rs (+14 -5)
📝 crates/client/src/error/dnssec_error.rs (+14 -5)
📝 crates/client/src/error/lexer_error.rs (+14 -5)
📝 crates/client/src/error/parse_error.rs (+14 -5)
📝 crates/https/Cargo.toml (+3 -2)
📝 crates/https/src/error.rs (+14 -5)
📝 crates/native-tls/Cargo.toml (+2 -1)
📝 crates/openssl/Cargo.toml (+2 -0)
📝 crates/proto/Cargo.toml (+2 -1)
📝 crates/proto/src/error.rs (+18 -6)
📝 crates/proto/src/lib.rs (+1 -0)
📝 crates/resolver/Cargo.toml (+2 -2)
📝 crates/resolver/src/error.rs (+14 -5)
📝 crates/rustls/Cargo.toml (+2 -1)
📝 crates/server/Cargo.toml (+3 -1)
📝 crates/server/src/error/config_error.rs (+14 -5)
📝 crates/server/src/error/persistence_error.rs (+14 -5)

📄 Description

Cherry-picks the original commit, but leaves backtrace at its current version 0.3.46 to reduce change delta. Can also bump if desirable, as well as set backtrace as a default feature if it would be considered a breaking change.

Closes #1385

depends on: #1405

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1387 **Author:** [@jmagnuson](https://github.com/jmagnuson) **Created:** 2/24/2021 **Status:** ✅ Merged **Merged:** 3/9/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `release/0.19` ← **Head:** `release/0.19-optional-backtrace` --- ### 📝 Commits (4) - [`3c0f690`](https://github.com/hickory-dns/hickory-dns/commit/3c0f6901a1b14ce701db47d01de9b7a55cc3d4b9) make backtrace dependency optional - [`171d24a`](https://github.com/hickory-dns/hickory-dns/commit/171d24a9031e4a73693ddff6e4447d84fce4fb94) fix backtrace feature naming - [`cca8363`](https://github.com/hickory-dns/hickory-dns/commit/cca83632e3237e2435b10897e35e34aedeb69945) enable backtrace feature by default for all crates - [`85e812e`](https://github.com/hickory-dns/hickory-dns/commit/85e812ee3d06951f95e2de87fa0441aef559e1da) Merge branch 'release/0.19' into release/0.19-optional-backtrace ### 📊 Changes **20 files changed** (+156 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+4 -4) 📝 `crates/async-std-resolver/Cargo.toml` (+2 -1) 📝 `crates/client/Cargo.toml` (+3 -1) 📝 `crates/client/src/error/client_error.rs` (+14 -5) 📝 `crates/client/src/error/dnssec_error.rs` (+14 -5) 📝 `crates/client/src/error/lexer_error.rs` (+14 -5) 📝 `crates/client/src/error/parse_error.rs` (+14 -5) 📝 `crates/https/Cargo.toml` (+3 -2) 📝 `crates/https/src/error.rs` (+14 -5) 📝 `crates/native-tls/Cargo.toml` (+2 -1) 📝 `crates/openssl/Cargo.toml` (+2 -0) 📝 `crates/proto/Cargo.toml` (+2 -1) 📝 `crates/proto/src/error.rs` (+18 -6) 📝 `crates/proto/src/lib.rs` (+1 -0) 📝 `crates/resolver/Cargo.toml` (+2 -2) 📝 `crates/resolver/src/error.rs` (+14 -5) 📝 `crates/rustls/Cargo.toml` (+2 -1) 📝 `crates/server/Cargo.toml` (+3 -1) 📝 `crates/server/src/error/config_error.rs` (+14 -5) 📝 `crates/server/src/error/persistence_error.rs` (+14 -5) </details> ### 📄 Description Cherry-picks the original commit, but leaves `backtrace` at its current version `0.3.46` to reduce change delta. Can also bump if desirable, as well as set `backtrace` as a default feature if it would be considered a breaking change. Closes #1385 ---- depends on: #1405 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>