[PR #1384] [MERGED] Take the current header truncated bit into account #2273

New issue

Closed

opened 2026-03-16 08:29:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:29:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1384
Author: @ilaidlaw
Created: 2/23/2021
Status: ✅ Merged
Merged: 3/5/2021
Merged by: @bluejekyll

Base: main ← Head: update-was-truncated

📝 Commits (3)

31b3fb2 Take the current header truncated bit into account
e1b0c3e Test that the truncate bit is encoded/decoded in the Message
a1f92ac Merge branch 'main' into update-was-truncated

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 crates/proto/src/op/message.rs (+3 -2)

📄 Description

We deserialize a message, examine the contents, and re-serialize it. We noticed that the new serialized message was missing the truncate bit. This patch fixes it in our case, but not sure if this is the correct approach in general. Welcome for feedback and suggestions on a different fix!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1384 **Author:** [@ilaidlaw](https://github.com/ilaidlaw) **Created:** 2/23/2021 **Status:** ✅ Merged **Merged:** 3/5/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `update-was-truncated` --- ### 📝 Commits (3) - [`31b3fb2`](https://github.com/hickory-dns/hickory-dns/commit/31b3fb2910c3ae4fcc0a772361a50410c9b75294) Take the current header truncated bit into account - [`e1b0c3e`](https://github.com/hickory-dns/hickory-dns/commit/e1b0c3e9cd94300f8b379919e5e2a466396a73bc) Test that the truncate bit is encoded/decoded in the Message - [`a1f92ac`](https://github.com/hickory-dns/hickory-dns/commit/a1f92acd0f06181d7bd0ec570bc3fb1743e803a4) Merge branch 'main' into update-was-truncated ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/message.rs` (+3 -2) </details> ### 📄 Description We deserialize a message, examine the contents, and re-serialize it. We noticed that the new serialized message was missing the `truncate` bit. This patch fixes it in our case, but not sure if this is the correct approach in general. Welcome for feedback and suggestions on a different fix! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>