[PR #1258] [MERGED] Fix presentation format of DS and DNSKEY records #2144

New issue

Closed

opened 2026-03-16 06:22:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 06:22:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1258
Author: @AluisioASG
Created: 10/20/2020
Status: ✅ Merged
Merged: 12/28/2020
Merged by: @bluejekyll

Base: main ← Head: aasg/fix-dnssec-rr-display

📝 Commits (4)

3492aeb fix presentation format of DS and DNSKEY records
8cc8304 Merge branch 'main' into aasg/fix-dnssec-rr-display
debe733 Merge branch 'main' into aasg/fix-dnssec-rr-display
4f571b1 Merge branch 'main' into aasg/fix-dnssec-rr-display

📊 Changes

8 files changed (+65 additions, -2 deletions)

View changed files

📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+1 -1)
➕ crates/proto/tests/dnssec_presentation_format_tests.rs (+56 -0)
➕ crates/proto/tests/test-data/.gitattributes (+1 -0)
➕ crates/proto/tests/test-data/rfc4034-2.3.key (+2 -0)
➕ crates/proto/tests/test-data/rfc4034-2.3.rdata (+1 -0)
➕ crates/proto/tests/test-data/rfc4034-5.4.key (+2 -0)
➕ crates/proto/tests/test-data/rfc4034-5.4.rdata (+1 -0)

📄 Description

Algorithms were formatted as their enum name rather than their integer value. Convert them to u8 (as is done with the digest type) and add tests based on the examples in RFC 4034.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1258 **Author:** [@AluisioASG](https://github.com/AluisioASG) **Created:** 10/20/2020 **Status:** ✅ Merged **Merged:** 12/28/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `aasg/fix-dnssec-rr-display` --- ### 📝 Commits (4) - [`3492aeb`](https://github.com/hickory-dns/hickory-dns/commit/3492aeb74a9da5eddbde5f564aeec93b2b27610f) fix presentation format of DS and DNSKEY records - [`8cc8304`](https://github.com/hickory-dns/hickory-dns/commit/8cc8304c7e7ac00bc1abe74bce35ecd451db1a55) Merge branch 'main' into aasg/fix-dnssec-rr-display - [`debe733`](https://github.com/hickory-dns/hickory-dns/commit/debe7338841894a529574e277b2081aad49c1db0) Merge branch 'main' into aasg/fix-dnssec-rr-display - [`4f571b1`](https://github.com/hickory-dns/hickory-dns/commit/4f571b15161b85b3d55a97fb61fd9a6596fe59e3) Merge branch 'main' into aasg/fix-dnssec-rr-display ### 📊 Changes **8 files changed** (+65 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+1 -1) ➕ `crates/proto/tests/dnssec_presentation_format_tests.rs` (+56 -0) ➕ `crates/proto/tests/test-data/.gitattributes` (+1 -0) ➕ `crates/proto/tests/test-data/rfc4034-2.3.key` (+2 -0) ➕ `crates/proto/tests/test-data/rfc4034-2.3.rdata` (+1 -0) ➕ `crates/proto/tests/test-data/rfc4034-5.4.key` (+2 -0) ➕ `crates/proto/tests/test-data/rfc4034-5.4.rdata` (+1 -0) </details> ### 📄 Description Algorithms were formatted as their enum name rather than their integer value. Convert them to `u8` (as is done with the digest type) and add tests based on the examples in RFC 4034. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>