[PR #1261] [MERGED] Support reading the root hints file #2143

Closed
opened 2026-03-16 06:22:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1261
Author: @mattias-p
Created: 10/22/2020
Status: Merged
Merged: 10/23/2020
Merged by: @djc

Base: mainHead: named-root


📝 Commits (2)

  • 6b54954 Support reading the root hints file
  • 24db8ff Merge branch 'main' into named-root

📊 Changes

3 files changed (+28 additions, -6 deletions)

View changed files

📝 crates/client/src/serialize/txt/zone.rs (+2 -1)
📝 crates/server/src/store/file/authority.rs (+1 -1)
📝 crates/server/tests/txt_tests.rs (+25 -4)

📄 Description

I want to parse the named.root file with trust_dns, but it's currently impossible because it contains no class fields. This PR adds the support I need as well as a unit test to keep it working.
The change is not API compatible. If you wish I'll make it compatible so long as you give me some direction how.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1261 **Author:** [@mattias-p](https://github.com/mattias-p) **Created:** 10/22/2020 **Status:** ✅ Merged **Merged:** 10/23/2020 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `named-root` --- ### 📝 Commits (2) - [`6b54954`](https://github.com/hickory-dns/hickory-dns/commit/6b54954988810963bdaa751ff1ec9c06a117c352) Support reading the root hints file - [`24db8ff`](https://github.com/hickory-dns/hickory-dns/commit/24db8ff3115d35829daf83afe2bf65c276858a73) Merge branch 'main' into named-root ### 📊 Changes **3 files changed** (+28 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/zone.rs` (+2 -1) 📝 `crates/server/src/store/file/authority.rs` (+1 -1) 📝 `crates/server/tests/txt_tests.rs` (+25 -4) </details> ### 📄 Description I want to parse the [named.root](https://www.internic.net/domain/named.root) file with trust_dns, but it's currently impossible because it contains no class fields. This PR adds the support I need as well as a unit test to keep it working. The change is not API compatible. If you wish I'll make it compatible so long as you give me some direction how. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 06:22:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2143
No description provided.